Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sit: 0.3.2 -> 0.4.0 #41863

Merged
merged 1 commit into from Jun 12, 2018
Merged

sit: 0.3.2 -> 0.4.0 #41863

merged 1 commit into from Jun 12, 2018

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jun 11, 2018 •
edited

Motivation for this change

New version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 11, 2018

@GrahamcOfBorg build sit

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sit

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `sit-web`.

To learn more, run the command again with --verbose.
builder for '/nix/store/1lrj67vg4xasmsg1rji6a4nfmg2hpmpw-sit-0.4.0.drv' failed with exit code 101
error: build of '/nix/store/1lrj67vg4xasmsg1rji6a4nfmg2hpmpw-sit-0.4.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 11, 2018

Darwin failure looks like it is missing libiconv, which needs to be explicitly listed as in buildInputs for darwin (not for linux, since it's provided by glibc).

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sit

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0
shrinking /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0/bin/sit
shrinking /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0/bin/sit-web
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0/bin
patching script interpreter paths in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0
checking for references to /build in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0...
/nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sit

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0
shrinking /nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0/bin/sit
shrinking /nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0/bin/sit-web
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0/bin
patching script interpreter paths in /nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0
checking for references to /build in /nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0...
/nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0

@yrashk yrashk force-pushed the sit-0.4.0 branch 2 times, most recently from 63d3585 to fae5988 Compare June 12, 2018 06:34
@yrashk
Copy link
Contributor Author

yrashk commented Jun 12, 2018

@xeji I've added libiconv for Darwin

@xeji
Copy link
Contributor

xeji commented Jun 12, 2018

@GrahamcOfBorg build sit

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sit

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `sit-web`.

To learn more, run the command again with --verbose.
builder for '/nix/store/hpc6lrfds7i8c6w97k0qw93jfg1mrwvj-sit-0.4.0.drv' failed with exit code 101
error: build of '/nix/store/hpc6lrfds7i8c6w97k0qw93jfg1mrwvj-sit-0.4.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sit

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0
shrinking /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0/bin/sit
shrinking /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0/bin/sit-web
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0/bin
patching script interpreter paths in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0
checking for references to /build in /nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0...
/nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: sit

Partial log (click to expand)

test no_records ... ok
test pgp_no_signature ... ok
test query ... ok
test record ... ok
test repo_over_named_user_query ... ok
test repo_over_named_user_filter ... ok
test pgp_signature ... test pgp_signature has been running for over 60 seconds
test pgp_signature_wrong_data ... test pgp_signature_wrong_data has been running for over 60 seconds
building of '/nix/store/bjlvibz2hrm16bizhldk7c6xc7kakzqs-sit-0.4.0.drv' timed out after 1800 seconds
error: build of '/nix/store/bjlvibz2hrm16bizhldk7c6xc7kakzqs-sit-0.4.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 12, 2018

Looks like you need to add the Security framework for darwin. This must be passed from top-leve/all-packages.nix by adding: inherit (darwin.apple_sdk.frameworks) Security,
see other examples in nixpkgs.

Sorry for the iterations, but I don't have access to a Mac either, so we'll have to do this step by step.

The timeout on x86_64-linux shouldn't be a problem if it builds locally.

@yrashk
Copy link
Contributor Author

yrashk commented Jun 12, 2018

@xeji I've updated the PR.

@xeji
Copy link
Contributor

xeji commented Jun 12, 2018

Thanks! Let's see:
@GrahamcOfBorg build sit

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sit

Partial log (click to expand)

/nix/store/kpjvg0c0v05h69a94hjdyjpdxlnzka6q-sit-0.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sit

Partial log (click to expand)

/nix/store/ddzbh88xd2bg2nyaqv1nl5ipr83a16dm-sit-0.4.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: sit

Partial log (click to expand)


failures:
    record_should_sign_if_configured
    record_should_sign_if_instructed_cmdline

test result: FAILED. 13 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p sit --test command_record'
builder for '/nix/store/ffxx3d43f57iby8i0dzf87zp19ldn2z5-sit-0.4.0.drv' failed with exit code 101
error: build of '/nix/store/ffxx3d43f57iby8i0dzf87zp19ldn2z5-sit-0.4.0.drv' failed

@yrashk
Copy link
Contributor Author

yrashk commented Jun 12, 2018

This is a known sporadic error in tests associated with invoking gpg -- at times it seems to not be able to connect to its gpg-agent. I've spent many hours on this but so far found no solution.

@yrashk
Copy link
Contributor Author

yrashk commented Jun 12, 2018

If it is not sporadic on this host, it might also be that gpg there is GnuPG 1.x and there is no gpg2

@xeji
Copy link
Contributor

xeji commented Jun 12, 2018

Great, at least it builds now but two test cases fail. Don't think it's worth trying to fix them without access to a Mac, so I suggest to disable tests for darwin.

@yrashk
Copy link
Contributor Author

yrashk commented Jun 12, 2018

I do have access to a Mac (it doesn't have Nixpkgs yet, though) -- and v0.4.0 passes tests most of the time. So the only thing I'd try to rule out is to check what's the version of GnuPG installed on that host. Any way to do that?

@xeji
Copy link
Contributor

xeji commented Jun 12, 2018

None that I know of.
Anyway, we could also merge it as is and see what happens on hydra.

@yrashk
Copy link
Contributor Author

yrashk commented Jun 12, 2018

We can do that. If it still fails, I can send another PR disabling tests on Darwin for the time being.

@xeji xeji merged commit f45fd23 into NixOS:master Jun 12, 2018
orivej added a commit that referenced this pull request Jun 12, 2018
@orivej
Merge branch 'master' into staging
7f3de60 
* master: (161 commits)
  pcsclite: clean up after #41790
  tor: 0.3.3.6 -> 0.3.3.7
  opae: init at 1.0.0
  tinc: 1.0.33 -> 10.0.34
  tinc_pre: 1.1pre15 -> 1.1pre16
  sit: 0.3.2 -> 0.4.0 (#41863)
  platforms/raspberrypi: enable kernelAutoModules
  libupnp: 1.6.21 -> 1.8.3 (#41684)
  androidStudioPackages.{dev,canary}: 3.2.0.16 -> 3.2.0.17
  tdesktop: 1.3.0 -> 1.3.7
  gns3Packages.{server,gui}{Stable,Preview}: 2.1.6 -> 2.1.7
  aws-sam-cli: init at 0.3.0 (#41877)
  nixos/nat: optional networking.nat.externalInterface (#41864)
  linux: 4.17 -> 4.17.1
  linux: 4.16.14 -> 4.16.15
  linux: 4.14.48 -> 4.14.49
  nixos/unbound: add restart (#41885)
  maintainers/create-azure.sh: remove hydra.nixos.org as binary cache (#41883)
  gshogi: init at 0.5.1 (#41840)
  neovim: add missing libiconv
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yrashk @xeji @GrahamcOfBorg