Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: integer kind deduction #6182

Merged
merged 2 commits into from Jun 21, 2018
Merged

Fix: integer kind deduction #6182

merged 2 commits into from Jun 21, 2018

Conversation

rGradeStd
Copy link
Contributor

@rGradeStd rGradeStd commented Jun 12, 2018 •
edited

Fixes #6175
Lexer were checking only the restrictions for the UInt64, but not for the Int64 (for the negative numbers).

straight-shoota
straight-shoota requested changes Jun 12, 2018
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add additional specs for this behaviour (especially validating edge cases).

@rGradeStd
Copy link
Contributor Author

@straight-shoota done

@ysbaddaden ysbaddaden merged commit 0e4a62a into crystal-lang:master Jun 21, 2018
@RX14 RX14 added this to the 0.25.1 milestone Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota requested changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rGradeStd @bcardiff @straight-shoota @ysbaddaden @RX14