Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Time on win32 #6181

Merged
merged 1 commit into from Jun 12, 2018
Merged

Fix Time on win32 #6181

merged 1 commit into from Jun 12, 2018

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Jun 12, 2018 •
edited

cc @straight-shoota, you wrote this original code

in src/crystal/system/win32/time.cr:116: no overload matches 'Time.utc' with types Int32, UInt16, Int32, UInt16, UInt16, UInt16
Overloads are:
 - Time.utc(year : Int32, month : Int32, day : Int32, hour : Int32 = 0, minute : Int32 = 0, second : Int32 = 0, *, nanosecond : Int32 = 0)
 - Time.utc(*, seconds : Int64, nanoseconds : Int32)

    time = ::Time.utc(year, systemtime.wMonth, day, systemtime.wHour, systemtime.wMinute, systemtime.wSecond)
                  ^~~

@Sija
Copy link
Contributor

Sija commented Jun 12, 2018

I think that's a regression caused by #6118.

@RX14
Copy link
Contributor Author

RX14 commented Jun 12, 2018

And #5819, actually

@ysbaddaden ysbaddaden merged commit 7d98e1f into crystal-lang:master Jun 12, 2018
@RX14 RX14 added this to the 0.25.1 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:bug platform:windows topic:stdlib
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RX14 @Sija @straight-shoota @sdogruyol @ysbaddaden