Skip to content
This repository has been archived by the owner on Mar 7, 2022. It is now read-only.

Apply check-config patches #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coderobe
Copy link

@coderobe coderobe commented May 21, 2018

I ran check-config from meta-asteroid/scripts over the defconfig and found some values that might want to be changed.

@MagneFire
Copy link
Member

Thanks for your contribution!

As with your other PR (AsteroidOS/meta-swift-hybris#6) this seems to contain configuration values that aren't relevant.

The CONFIG_BT=y change is actually not valid for this kernel since we use a backported Bluetooth subsystem https://github.com/AsteroidOS/meta-tetra-hybris/blob/master/recipes-kernel/linux/linux-tetra/defconfig#L3749.

All other options are automatically removed by the kernel configuration since they aren't valid in the kernel.

I should probably also add that CONFIG_DEFAULT_SECURITY_DAC=y is the right option here as this is used when SELinux is disabled (which is what we want). You may be on to something here actually. The option in the check-config appears to be incorrectly set to disable: https://github.com/AsteroidOS/meta-asteroid/blob/master/scripts/check-config#L220.

Feel free to create a PR in meta-asteroid (https://github.com/AsteroidOS/meta-asteroid/pulls) if you want that last specific issue 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants