Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 44c61572cd32
Choose a base ref
...
head repository: jruby/jruby
compare: 69c0c2d3b275
Choose a head ref
  • 6 commits
  • 16 files changed
  • 1 contributor

Commits on May 22, 2018

  1. [spec] cleanup some of the regression specs -> no RUBY > '1.9' checks

    @kares
    kares committed May 22, 2018
    Copy the full SHA
    838e22c View commit details
    Browse the repository at this point in the history

  2. [refactor] dry-out exception: keyword extraction in socket classes

    @kares
    kares committed May 22, 2018
    Copy the full SHA
    2ab6bc3 View commit details
    Browse the repository at this point in the history

  3. [refactor] use method exception param + review keyword extraction

    @kares
    kares committed May 22, 2018
    Copy the full SHA
    bbc8542 View commit details
    Browse the repository at this point in the history

  4. [refactor] do keyword lookup once & opts check as well (add override)

    @kares
    kares committed May 22, 2018
    Copy the full SHA
    a35c843 View commit details
    Browse the repository at this point in the history

  5. [refactor] do not encode Symbol -> String; proper constant naming

    @kares
    kares committed May 22, 2018
    Copy the full SHA
    d39c58c View commit details
    Browse the repository at this point in the history

  6. [refactor] return same string instance when nil buffer given on pack

    @kares
    kares committed May 22, 2018
    Copy the full SHA
    69c0c2d View commit details
    Browse the repository at this point in the history