Freeciv: enable on darwin #40904
Merged
Freeciv: enable on darwin #40904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fetchurl -> fetchFromGitHub - Update URLs: joelthelion -> wting - mkdir + cp -> install - Use -z flag to set zshshare_dir - Add me as a maintainer - Use recursive version instead of let - meta: with stdenv.lib; ...
Ideally I'd like the whole `nixos`/`nixpkgs` channel distinction to disappear, but this is a step along that path. After a while being in this state, we can stop creating the magic `nixpkgs -> .` symlink inside our `nixos` channel tarballs and simplify that whole mess a bit.
Stop requiring the nixpkgs symlink in NixOS channel tarballs
…e-nix-for-darwin wireguard: bump version and limit platforms
kakoune-unstable: 2018-03-22 -> 2018-05-21, debug mode disabled
autojump: rework
This is how we do overrides elsewhere. The "name" suffix makes things a little bit complicated IMO. Other input welcome.
URL: https://gitlab.gnome.org/GNOME/gtk/issues/303 This patch will fix the assertion generated at startup for freeciv on macOS. Conditionally applied on Darwin. Gdk:ERROR:gdkimage-quartz.c:250:_gdk_image_new_for_depth: assertion failed: (depth == 24 || depth == 32)
GrahamcOfBorg
added
6.topic: darwin
|
Success on x86_64-linux (full log) Attempted: freeciv, gtk2 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: autojump, enet, freeciv, gtk2, nvidia-texture-tools, sfml, spidermonkey_38 The following builds were skipped because they don't evaluate on x86_64-linux: wireguard-go Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: freeciv, gtk2 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: freeciv, gtk2 Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: autojump, enet, freeciv, gtk2, nvidia-texture-tools, sfml, spidermonkey_38, wireguard-go Partial log (click to expand)
|
|
Homebrew disables some gtk tests for freeciv: https://github.com/Linuxbrew/homebrew-core/blob/730680cb01e966ea83c7924c8957cf76be1282a6/Formula/freeciv.rb#L55 |
|
Failure on aarch64-linux (full log) Attempted: autojump, enet, freeciv, gtk2, nvidia-texture-tools, sfml, spidermonkey_38 The following builds were skipped because they don't evaluate on aarch64-linux: wireguard-go Partial log (click to expand)
|
|
Tests are currently disabled anyway. I bet we will have to disable those if they break in headless environments though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get the GTK client of FreeCiv working at least. Not sure how to get the SDL one though.