Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-dashboard: raise memory limit to 250MB #40905

Merged
merged 1 commit into from
May 22, 2018
Merged

kubernetes-dashboard: raise memory limit to 250MB #40905

merged 1 commit into from
May 22, 2018
+1 −1

Conversation

kliu128
Copy link

@kliu128 kliu128 commented May 22, 2018 •
edited
Loading

On my cluster, I often get OOM errors that cause the dashboard to crash just by going over 50MB.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

kubernetes-dashboard: raise memory limit to 250MB
b6f2e75 
On my cluster, I often get OOM errors that cause the dashboard to crash just by going over 50MB.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 22, 2018
@Mic92
Copy link
Member

Mic92 commented May 22, 2018

cc @offlinehacker @globin

@offlinehacker offlinehacker merged commit 856ffc6 into NixOS:master May 22, 2018
@kliu128 kliu128 deleted the patch-2 branch May 22, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kliu128 @Mic92 @offlinehacker @GrahamcOfBorg