This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
Apply check-config patches #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I thought I did that when I was working on the initial port. Have you tried to build an image with these changes and boot it? |
|
I haven't. I had ran the script over the bass defconfig and tested that one (AsteroidOS/meta-bass-hybris#5) and then just ran it on all the device configs. Please test this if you have the time, though i don't see why this would cause issues - as the changes aren't huge. |
|
I tested your patch and it causes a small regression but I will merge your PR and fix the regression straight away. |
MagneFire
pushed a commit
to MagneFire/meta-sparrow-hybris
that referenced
this pull request
Oct 22, 2021
Apply check-config patches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran check-config from meta-asteroid/scripts over the defconfig and found some values that might want to be changed.