Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purple-xmpp-http-upload: init at 178096c #40908

Merged
merged 1 commit into from May 22, 2018
Merged

purple-xmpp-http-upload: init at 178096c #40908

merged 1 commit into from May 22, 2018

Conversation

emmanuelrosa
Copy link
Contributor

Motivation for this change

Adds purple-xmpp-http-upload pidgin/libpurple plugin, which provides support for HTTP File Upload (XMPP Protocol XEP-0363). This allows libpurple clients to send files via XMPP to clients which support XEP-0363.

Note: This will not allow you to send files to Conversations (Android XMPP client). Conversations uses Jingle (a different XEP) for file transfers.

Important: Be mindful that even when using OMEMO (lurch plugin) files are sent clear-text.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [ ] macOS
    • other Linux distributions (Tested on Xubuntu)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" New package, so there are no dependents.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented May 22, 2018

@GrahamcOfBorg build purple-xmpp-http-upload

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: purple-xmpp-http-upload

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w3qjwgbmhzdxk5khiz95g4hxmnim3sgr-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37
shrinking /nix/store/w3qjwgbmhzdxk5khiz95g4hxmnim3sgr-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37/lib/purple-2/jabber_http_file_upload.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w3qjwgbmhzdxk5khiz95g4hxmnim3sgr-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37/lib
patching script interpreter paths in /nix/store/w3qjwgbmhzdxk5khiz95g4hxmnim3sgr-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37
checking for references to /build in /nix/store/w3qjwgbmhzdxk5khiz95g4hxmnim3sgr-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37...
/nix/store/w3qjwgbmhzdxk5khiz95g4hxmnim3sgr-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: purple-xmpp-http-upload

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3adzgg9sxwm5wqsq939y43cznq0s39mi-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37
shrinking /nix/store/3adzgg9sxwm5wqsq939y43cznq0s39mi-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37/lib/purple-2/jabber_http_file_upload.so
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3adzgg9sxwm5wqsq939y43cznq0s39mi-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37/lib
patching script interpreter paths in /nix/store/3adzgg9sxwm5wqsq939y43cznq0s39mi-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37
checking for references to /build in /nix/store/3adzgg9sxwm5wqsq939y43cznq0s39mi-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37...
/nix/store/3adzgg9sxwm5wqsq939y43cznq0s39mi-purple-xmpp-upload-178096cbfc9df165c2dc1677666439969d212b37

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: purple-xmpp-http-upload

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92 Mic92 merged commit 5a7e42f into NixOS:master May 22, 2018
@Mic92
Copy link
Member

Mic92 commented May 22, 2018

I also changed the version number to be the date of commit: 090b7cc

@emmanuelrosa emmanuelrosa deleted the purple-xmpp-http-upload branch May 22, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emmanuelrosa @Mic92 @GrahamcOfBorg