wireguard-tools: clean up, wrap w/ wireguard-go on Darwin #40907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zx2c4
reviewed
May 22, 2018
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://www.wireguard.com/; | ||
| downloadPage = https://git.zx2c4.com/WireGuard/refs/; |
There was a problem hiding this comment.
Why was this line removed from wireguard-tools.nix but kept in wireguard.nix?
There was a problem hiding this comment.
Didn't mean to remove. You noticed faster than I could amend :-)
lukateras
force-pushed
the
20180522.041617/wireguard-tools-cleanup
branch
from
e324de6
to
e9e044a
Compare
zx2c4
reviewed
May 22, 2018
| "DESTDIR=$(out)" | ||
| "PREFIX=/" | ||
| "-C" "tools" | ||
| "WITH_BASHCOMPLETION=yes" | ||
| "WITH_SYSTEMDUNITS=yes" |
There was a problem hiding this comment.
Why not keep the useSystemd mark in here? It's indeed really useless on macOS.
There was a problem hiding this comment.
Smaller variability helps package maintenance. In this case, useSystemd required conditional patch in postFixup phase. Given that it's just a text file, it seems to be easier to copy and patch anyway than to decide based on platform.
|
Success on x86_64-linux (full log) Attempted: wireguard-tools Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: wireguard-tools Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: wireguard-tools Partial log (click to expand)
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kirelagin @zx2c4
Cleans up derivation (consolidates some things), also note that systemd unit is now built unconditionally (it is just a text file anyway). On Darwin,
wgandwg-quickare wrapped together withwireguard-go.