Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wireguard: bump version and limit platforms #40902

Merged

Conversation

zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented May 22, 2018

This is not Linux or Windows software. The only platform this meant to be packaged for at the moment is Darwin. Do not package this for Linux. And obviously you didn't even test this on Windows since it doesn't build there.

@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

Choose whether you'd like #40901 or this. I'd personally prefer #40901, but I don't know much about your Mac users.

@lukateras
Copy link
Member

lukateras commented May 22, 2018

Software being included into Nixpkgs just means someone uses it, not an endorsement of any sort. Maybe we should mark it as alpha-quality software in the description? Merging this on behalf of @kirelagin who added wireguard-go to tree in the first place.

@lukateras lukateras merged commit 643462a into NixOS:master May 22, 2018
@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

It's not about this being alpha quality. It's about this not being meant for Linux. No need to change the description.

@lukateras
Copy link
Member

lukateras commented May 22, 2018

I thought that wireguard-go is used in Android as userspace fallback, so that means it should build on Linux? (This package was introduced by a Darwin user.)

@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

We do freaky things to this on Android, and it's not built from this source alone. This is not meant to be packaged in Linux distributions. The current makefile even bails if you try.

@lukateras
Copy link
Member

OK, thanks for explanation.

@flokli
Copy link
Contributor

flokli commented May 22, 2018

So building it on darwin is okay? Or should we mark this as broken, too?

@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

Darwin is fine (here's the formula that I wrote for Homebrew). The next version will also support FreeBSD, if Nix runs on that.

@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

By the way, as a matter of dependencies, wireguard-tools should have dependencies now depending on the platform. It should depend on the wireguard module package on Linux and the wireguard-go package on Darwin.


Based on your comment, "this package was introduced by a Darwin user," I added instructions to https://www.wireguard.com/install about nixOS on darwin. Could you let me know if those look correct?

@flokli
Copy link
Contributor

flokli commented May 22, 2018

Well, there seems to be some work going on for netbsd by @matthewbauer (but no idea if it runs or not).

@zx2c4 do you want to add yourself as maintainer for wireguard, wireguard-go and wireguard-tools? In that way, you should get notified if PRs touch these, or if there are breakages on the hydra builds :-)

@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

I'm already a maintainer on the first and last of those, but not on wireguard-go; nobody even CCd me that it was being added. So sure, I'll send a PR and add myself.

@lukateras
Copy link
Member

lukateras commented May 22, 2018

Could you let me know if those look correct?

No, this would only work for NixOS system-wide config, not for Nix on Darwin. It should be:

$ nix-env -iA nixpkgs.wireguard-go nixpkgs.wireguard-tools

That said, please add just this and I'll fix the package right away (i.e. by adding missing dependency):

$ nix-env -iA nixpkgs.wireguard-tools

@zx2c4
Copy link
Contributor Author

zx2c4 commented May 22, 2018

Thanks, fixed the webpage.

@globin
Copy link
Member

globin commented May 22, 2018

Also should be "Nix on Darwin" if we'd want to start nitpicking :)

@krytarowski
Copy link

Any progress on the NetBSD port?

@matthewbauer
Copy link
Member

matthewbauer commented May 23, 2018

@krytarowski So it's more of a port of NetBSD userland to Nix. Certain command line tools like getent and getconf can be compiled to work on any Nix platform with the help of nbcompat.

Job: https://hydra.nixos.org/job/nixpkgs/trunk/netbsd.getent.x86_64-linux

The main use case right now is when you want to use Musl as your libc (glibc provides getent & getconf on Linux systems currently). Eventually I want to work towards building the whole NetBSD kernel & use it as a drop-in for a NixOS system kind of like how GNU/kfreebsd works. This is a ways off though.

As far as ports of Nix to NetBSD, you can most likely use it right now with the "native" stdenv: https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/native/default.nix. It would be nice to have a "pure" stdenv for NetBSD but I haven't looked into it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants