Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.4.23 -> 0.4.24 #41631

Merged
merged 1 commit into from Jun 10, 2018
Merged

solc: 0.4.23 -> 0.4.24 #41631

merged 1 commit into from Jun 10, 2018

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Jun 7, 2018 •
edited

Motivation for this change

Update the package. Enable the test.

Things done
  1. boost-shared-libs.patch removed. (because it have been fixed by upstream)
  2. The CMAKE_INSTALL_LIBDIR fix is needed because it will cause build failure.
  3. I removed substituteInPlace cmake/EthCompilerSettings.cmake --replace "add_compile_options(-Werror)" "" (I guess this is ok because it still builds)

cc maintainers @dbrock @akru

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 9, 2018

@GrahamcOfBorg build solc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: solc

Partial log (click to expand)

/nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24
shrinking /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/lib/libdevcore.so
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/lib  /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/bin
patching script interpreter paths in /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24
checking for references to /build in /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24...
shrinking RPATHs of ELF executables and libraries in /nix/store/995wx34sr55a9m3mh3knads23sf082r7-solc-0.4.24-dev
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/995wx34sr55a9m3mh3knads23sf082r7-solc-0.4.24-dev
checking for references to /build in /nix/store/995wx34sr55a9m3mh3knads23sf082r7-solc-0.4.24-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24/lib/libdevcore.so
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24/lib  /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24/bin
patching script interpreter paths in /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24
checking for references to /build in /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24...
shrinking RPATHs of ELF executables and libraries in /nix/store/b54bjaaw46j1jnsab4a3lqixsfjls602-solc-0.4.24-dev
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b54bjaaw46j1jnsab4a3lqixsfjls602-solc-0.4.24-dev
checking for references to /build in /nix/store/b54bjaaw46j1jnsab4a3lqixsfjls602-solc-0.4.24-dev...
/nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: solc

Partial log (click to expand)

[ 99%] Building CXX object test/tools/CMakeFiles/solfuzzer.dir/fuzzer.cpp.o
[100%] Linking CXX executable solfuzzer
[100%] Built target solfuzzer
running tests
dyld: Library not loaded: libsolc.dylib
  Referenced from: /private/tmp/nix-build-solc-0.4.24.drv-0/source/build/./test/soltest
  Reason: image not found
/nix/store/3ydl37rpwsb0qm274b72qi5pq55v2bv9-stdenv-darwin/setup: line 1289: 95064 Abort trap: 6           LD_LIBRARY_PATH=./libsolc:./libsolidity:./liblll:./libevmasm:./libdevcore:$LD_LIBRARY_PATH ./test/soltest -p -- --no-ipc --no-smt --testpath ../test
builder for '/nix/store/v7l6a02d638bl2ci705f1nc7k6dgv6zv-solc-0.4.24.drv' failed with exit code 134
error: build of '/nix/store/v7l6a02d638bl2ci705f1nc7k6dgv6zv-solc-0.4.24.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 9, 2018

Please fix or disable the tests on darwin to avoid a regression.

@sifmelcara
solc: 0.4.23 -> 0.4.24
ab56a83 
Also enable test
@sifmelcara
Copy link
Member Author

Tests disabled if on darwin or cross compiling.

@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

@GrahamcOfBorg build solc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/bin/solc
shrinking /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/bin/lllc
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/lib  /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24/bin
patching script interpreter paths in /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24
checking for references to /build in /nix/store/7rqba00j5d3s3ah6g8nq0p4drcrk2zch-solc-0.4.24...
shrinking RPATHs of ELF executables and libraries in /nix/store/995wx34sr55a9m3mh3knads23sf082r7-solc-0.4.24-dev
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/995wx34sr55a9m3mh3knads23sf082r7-solc-0.4.24-dev
checking for references to /build in /nix/store/995wx34sr55a9m3mh3knads23sf082r7-solc-0.4.24-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24/lib/libdevcore.so
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24/lib  /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24/bin
patching script interpreter paths in /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24
checking for references to /build in /nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24...
shrinking RPATHs of ELF executables and libraries in /nix/store/b54bjaaw46j1jnsab4a3lqixsfjls602-solc-0.4.24-dev
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b54bjaaw46j1jnsab4a3lqixsfjls602-solc-0.4.24-dev
checking for references to /build in /nix/store/b54bjaaw46j1jnsab4a3lqixsfjls602-solc-0.4.24-dev...
/nix/store/rqbgs2rqwzsbxrzfi5v42190hsv0r6p1-solc-0.4.24

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: solc

Partial log (click to expand)

-- Installing: /nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24/bin/solc
-- Installing: /nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24/lib/liblll.dylib
-- Installing: /nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24/bin/lllc
/nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24
post-installation fixup
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24/lib  /nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24/bin
patching script interpreter paths in /nix/store/l36h0kz273psr82qhblqdr279p1q8q94-solc-0.4.24
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rq6dfjzdlznmcz8wcgmidlv3l5w3h4z3-solc-0.4.24-dev

@xeji xeji merged commit 5095e9e into NixOS:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sifmelcara @xeji @GrahamcOfBorg