New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.Tensorflow: fix dependencies #41628
Conversation
, markdown | ||
, futures | ||
}: | ||
|
||
# tensorflow is built from a downloaded wheel, because | ||
# https://github.com/tensorflow/tensorboard/issues/719 | ||
# blocks buildBazelPackage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Why do you drop the comment ? It is still downloaded as a wheel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was incorrect due to 'tensorflow' being mentioned instead of 'tensorboard'. Looks like I was wrong.
@GrahamcOfBorg build python2.pkgs.gast python3.pkgs.gast |
|
||
buildPythonPackage rec { | ||
pname = "gast"; | ||
name = "${pname}-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name
attribute is added by buildPython*
and should therefore be removed.
buildPythonPackage rec { | ||
pname = "gast"; | ||
name = "${pname}-${version}"; | ||
version = "0.2.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation
Failure on x86_64-linux (full log) Attempted: python2.pkgs.gast, python3.pkgs.gast Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python2.pkgs.gast, python3.pkgs.gast Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: python2.pkgs.gast, python3.pkgs.gast Partial log (click to expand)
|
I get the same error as @GrahamcOfBorg on NixOS |
@FRidh Thanks for the review. I do believe that I applied all the changes that you requested. |
@globin looks like a transient error though (server failure). |
No linux depends on |
Update for dfc4744.
@globin Alright, sorry to be so dense. It should be fixed now. |
@GrahamcOfBorg build python2.pkgs.gast python3.pkgs.gast |
Success on aarch64-linux (full log) Attempted: python2.pkgs.gast, python3.pkgs.gast Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python2.pkgs.gast, python3.pkgs.gast Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: python2.pkgs.gast, python3.pkgs.gast Partial log (click to expand)
|
Motivation for this change
Tensorflow binary is missing dependencies
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)