Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.Tensorflow: fix dependencies #41628

Merged
merged 5 commits into from Jun 10, 2018
Merged

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Jun 7, 2018

Motivation for this change

Tensorflow binary is missing dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

, markdown
, futures
}:

# tensorflow is built from a downloaded wheel, because
# https://github.com/tensorflow/tensorboard/issues/719
# blocks buildBazelPackage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Why do you drop the comment ? It is still downloaded as a wheel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was incorrect due to 'tensorflow' being mentioned instead of 'tensorboard'. Looks like I was wrong.

@FRidh FRidh changed the title Tensorflow deps fix pythonPackages.Tensorflow: fix dependencies Jun 7, 2018
@FRidh
Copy link
Member

FRidh commented Jun 7, 2018

@GrahamcOfBorg build python2.pkgs.gast python3.pkgs.gast


buildPythonPackage rec {
pname = "gast";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed.

buildPythonPackage rec {
pname = "gast";
name = "${pname}-${version}";
version = "0.2.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indentation

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.gast, python3.pkgs.gast

Partial log (click to expand)

Reading https://pypi.python.org/simple/astunparse/
Download error on https://pypi.python.org/simple/astunparse/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'astunparse' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for astunparse
error: Could not find suitable distribution for Requirement.parse('astunparse')
builder for '/nix/store/gks50mwknlq2as466735ys5j6gfavq1i-python3.6-gast-0.2.0.drv' failed with exit code 1
error: build of '/nix/store/c1yd04sqs4f99r1z8zczwx0y23zlnrmn-python2.7-gast-0.2.0.drv', '/nix/store/gks50mwknlq2as466735ys5j6gfavq1i-python3.6-gast-0.2.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.gast, python3.pkgs.gast

Partial log (click to expand)

OK
testParse (tests.test_self.SelfTestCase) ... ok
test_unparse (tests.test_self.SelfTestCase) ... ok

----------------------------------------------------------------------
Ran 22 tests in 0.161s

OK
/nix/store/wb7md196ajxyfr0kf383l165lrypgyk5-python2.7-gast-0.2.0
/nix/store/9lzxn69v22177a8rz8m2wkrixs2ryrri-python3.6-gast-0.2.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.gast, python3.pkgs.gast

Partial log (click to expand)

Reading https://pypi.python.org/simple/astunparse/
Download error on https://pypi.python.org/simple/astunparse/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'astunparse' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for astunparse
error: Could not find suitable distribution for Requirement.parse('astunparse')
builder for '/nix/store/9lbsdw8d6g1b81syiwlcz44ywnhyh118-python3.6-gast-0.2.0.drv' failed with exit code 1
error: build of '/nix/store/9lbsdw8d6g1b81syiwlcz44ywnhyh118-python3.6-gast-0.2.0.drv', '/nix/store/s39qb79wlrxw2si9vfsxkrn7453qg1vr-python2.7-gast-0.2.0.drv' failed

@globin
Copy link
Member

globin commented Jun 7, 2018

I get the same error as @GrahamcOfBorg on NixOS

@jyp
Copy link
Contributor Author

jyp commented Jun 8, 2018

@FRidh Thanks for the review. I do believe that I applied all the changes that you requested.

@jyp
Copy link
Contributor Author

jyp commented Jun 8, 2018

@globin looks like a transient error though (server failure).

@globin
Copy link
Member

globin commented Jun 8, 2018

No linux depends on astunparse being in the checkInputs

@jyp
Copy link
Contributor Author

jyp commented Jun 8, 2018

@globin Alright, sorry to be so dense. It should be fixed now.

@globin
Copy link
Member

globin commented Jun 9, 2018

@GrahamcOfBorg build python2.pkgs.gast python3.pkgs.gast

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.gast, python3.pkgs.gast

Partial log (click to expand)

test_JoinedStr (tests.test_compat.CompatTestCase) ... ok
test_KeywordOnlyArgument (tests.test_compat.CompatTestCase) ... ok
test_TryExceptNamed (tests.test_compat.CompatTestCase) ... ok

----------------------------------------------------------------------
Ran 22 tests in 1.068s

OK
/nix/store/flgyx4l0m3g620q628zf8zadjscx5a38-python2.7-gast-0.2.0
/nix/store/k2b6v6gqzi7djgwsg9zflsrr6x3m1jkz-python3.6-gast-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.gast, python3.pkgs.gast

Partial log (click to expand)

testCompile (tests.test_self.SelfTestCase) ... ok
testParse (tests.test_self.SelfTestCase) ... ok
test_unparse (tests.test_self.SelfTestCase) ... ok

----------------------------------------------------------------------
Ran 22 tests in 0.197s

OK
/nix/store/b9052qw3m86fyls0gd76ljsqnzxl5dpb-python2.7-gast-0.2.0
/nix/store/wazpwmx9m6ijcqix545fhihc1cg5jv6a-python3.6-gast-0.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.gast, python3.pkgs.gast

Partial log (click to expand)

testCompile (tests.test_self.SelfTestCase) ... ok
testParse (tests.test_self.SelfTestCase) ... ok
test_unparse (tests.test_self.SelfTestCase) ... ok

----------------------------------------------------------------------
Ran 22 tests in 0.149s

OK
/nix/store/jg2hdsx0309h0yakhjad3lmydn0rix1n-python2.7-gast-0.2.0
/nix/store/k64i6dlxrgjcw9xnpalbqqx4ag5vyy1h-python3.6-gast-0.2.0

@FRidh FRidh merged commit d358525 into NixOS:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants