New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc update #41640
doc update #41640
Conversation
This was put together based on feedback from LnL on IRC.
@@ -133,8 +133,9 @@ in | |||
will set up automatically for each build. This prevents | |||
impurities in builds by disallowing access to dependencies | |||
outside of the Nix store. This isn't enabled by default for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence looks a bit out of context after mentioning performance.
How about?
This prevents impurities in builds by disallowing access to dependencies outside of the Nix store with network- and mount namespaces.
@Mic92 OK, sounds good, I also changed it up a bit more to improve general clarity, though please do fact check me. |
in builds by disallowing access to dependencies outside of the Nix | ||
store by using network and mount namespaces in a chroot environment. | ||
This isn't enabled by default for possible performance penalties | ||
resulting form running in an isolated network and mount namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be confusing since the build is not running slower due the fact it is running a different namespace.
Instead creating a sandbox takes time itself which is especially relevant if many short-running derivations (i.e creating a configuration file in NixOS) are build:
This is not enabled by default for performance reason due to the initial setup time of a sandbox for each build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mic92 OK, good, that meshes better with my world view anyway - I was confused by the original phrasing as well. - thanks!
This was put together based on feedback from LnL on IRC.
Motivation for this change
Improving documentation