doc update #41640
Merged
doc update #41640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was put together based on feedback from LnL on IRC.
Mic92
reviewed
Jun 7, 2018
| @@ -133,8 +133,9 @@ in | |||
| will set up automatically for each build. This prevents | |||
| impurities in builds by disallowing access to dependencies | |||
| outside of the Nix store. This isn't enabled by default for | |||
There was a problem hiding this comment.
The sentence looks a bit out of context after mentioning performance.
How about?
This prevents impurities in builds by disallowing access to dependencies outside of the Nix store with network- and mount namespaces.
|
@Mic92 OK, sounds good, I also changed it up a bit more to improve general clarity, though please do fact check me. |
Mic92
reviewed
Jun 7, 2018
| in builds by disallowing access to dependencies outside of the Nix | ||
| store by using network and mount namespaces in a chroot environment. | ||
| This isn't enabled by default for possible performance penalties | ||
| resulting form running in an isolated network and mount namespace. |
There was a problem hiding this comment.
This could be confusing since the build is not running slower due the fact it is running a different namespace.
Instead creating a sandbox takes time itself which is especially relevant if many short-running derivations (i.e creating a configuration file in NixOS) are build:
This is not enabled by default for performance reason due to the initial setup time of a sandbox for each build.
There was a problem hiding this comment.
@Mic92 OK, good, that meshes better with my world view anyway - I was confused by the original phrasing as well. - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was put together based on feedback from LnL on IRC.
Motivation for this change
Improving documentation