Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openblas: remove patch that's no longer needed (PR merged) #41639

Merged
merged 2 commits into from Jun 7, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 7, 2018

As-is this fails to build since the patch doesn't apply.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

This shouldn't be a mass rebuild right? Could you see if patches = [] fixes this?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openblas

Partial log (click to expand)

Install OK!
make[1]: Leaving directory '/build/OpenBLAS-0.3.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0
shrinking /nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0/lib/libopenblas_armv8p-r0.3.0.dev.so
strip is /nix/store/3ki967c3ij4zi1q9ycc3g1vfwr608nrb-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0/lib  /nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0/bin
patching script interpreter paths in /nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0
checking for references to /build in /nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0...
/nix/store/xb80dyv31df6fx8mdcxkivsh9m1kq8fh-openblas-0.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openblas

Partial log (click to expand)

Generating OpenBLASConfigVersion.cmake in /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0/lib/cmake/openblas
Install OK!
make[1]: Leaving directory '/build/OpenBLAS-0.3.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0
shrinking /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0/lib/libopenblasp-r0.3.0.dev.so
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0/lib  /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0/bin
patching script interpreter paths in /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0
checking for references to /build in /nix/store/pdv4gjsd4b5nlkh1k82xg0v8x3nww3kq-openblas-0.3.0...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: openblas

Partial log (click to expand)

clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/j9wm8cmpszcyfcl8lsbn0j3zw1cxjx09-libc++-5.0.2/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-isystem /nix/store/j9wm8cmpszcyfcl8lsbn0j3zw1cxjx09-libc++-5.0.2/include' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-F/nix/store/jm3ac6lisvvlkqixxc4aih578w6makzx-CF-osx-10.10.5/Library/Frameworks' [-Wunused-command-line-argument]
clang-5.0: warning: argument unused during compilation: '-F/nix/store/jm3ac6lisvvlkqixxc4aih578w6makzx-CF-osx-10.10.5/Library/Frameworks' [-Wunused-command-line-argument]
gfortran -O2 -m128bit-long-double -Wall -m64 -fdefault-integer-8 -fPIC -c -o clahef_rk.o clahef_rk.f
gfortran -O2 -m128bit-long-double -Wall -m64 -fdefault-integer-8 -fPIC -c -o clahqr.o clahqr.f
f951: Warning: command line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: command line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
building of '/nix/store/2qbmcg7dmmdh2b67val4jdacgmdp9ar0-openblas-0.3.0.drv' timed out after 1800 seconds
error: build of '/nix/store/2qbmcg7dmmdh2b67val4jdacgmdp9ar0-openblas-0.3.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openblas

Partial log (click to expand)

these paths will be fetched (1.97 MiB download, 10.57 MiB unpacked):
  /nix/store/7778440yqj6g3hcaq433i0zrc41ybyzk-openblas-0.3.0
copying path '/nix/store/7778440yqj6g3hcaq433i0zrc41ybyzk-openblas-0.3.0' from 'https://cache.nixos.org'...
/nix/store/7778440yqj6g3hcaq433i0zrc41ybyzk-openblas-0.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openblas

Partial log (click to expand)

these paths will be fetched (3.70 MiB download, 37.29 MiB unpacked):
  /nix/store/5c5ncg08ikzgxyqv2lfc5zqj7a9s5s4b-openblas-0.3.0
copying path '/nix/store/5c5ncg08ikzgxyqv2lfc5zqj7a9s5s4b-openblas-0.3.0' from 'https://cache.nixos.org'...
/nix/store/5c5ncg08ikzgxyqv2lfc5zqj7a9s5s4b-openblas-0.3.0

@dtzWill
Copy link
Member Author

dtzWill commented Jun 7, 2018

EDIT: I missed the labels being removed, whoops. Woohoo!

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openblas

Partial log (click to expand)

Generating openblas.pc in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib/pkgconfig
Generating OpenBLASConfig.cmake in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib/cmake/openblas
Generating OpenBLASConfigVersion.cmake in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib/cmake/openblas
Install OK!
make[1]: Leaving directory '/private/tmp/nix-build-openblas-0.3.0.drv-0/OpenBLAS-0.3.0'
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib  /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/bin
patching script interpreter paths in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0
/nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0

@matthewbauer
Copy link
Member

Oh yeah it's going to be a mass rebuild on Darwin no matter what because there's no glibc.

@dtzWill
Copy link
Member Author

dtzWill commented Jun 7, 2018

Okay, great. Just to double-check... yep here's the latest Hydra build: https://hydra.nixos.org/build/75603189/nixlog/1

@dtzWill dtzWill merged commit 75eeb5f into NixOS:staging Jun 7, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openblas

Partial log (click to expand)

/nix/store/7778440yqj6g3hcaq433i0zrc41ybyzk-openblas-0.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openblas

Partial log (click to expand)

/nix/store/5c5ncg08ikzgxyqv2lfc5zqj7a9s5s4b-openblas-0.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: openblas

Partial log (click to expand)

Generating openblas.pc in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib/pkgconfig
Generating OpenBLASConfig.cmake in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib/cmake/openblas
Generating OpenBLASConfigVersion.cmake in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib/cmake/openblas
Install OK!
make[1]: Leaving directory '/private/tmp/nix-build-openblas-0.3.0.drv-0/OpenBLAS-0.3.0'
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/lib  /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0/bin
patching script interpreter paths in /nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0
/nix/store/aybfrfn64a0661qwvwkjm5hdw2rg4bnb-openblas-0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants