Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell infra: Use self.ghc rather than closing over initial value #41641

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

If someone takes haskellSrc2nix from a different package set to avoid hydra IFD problems when the hydra eval is a different platform than build or host, it fails because the wrong --compiler is being passed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from peti as a code owner June 7, 2018 18:31
@Ericson2314 Ericson2314 requested a review from srhb June 7, 2018 18:31
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 7, 2018
@Ericson2314 Ericson2314 merged commit 23f2dfd into NixOS:master Jun 7, 2018
@Ericson2314 Ericson2314 deleted the haskell-infra-latebind branch June 7, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants