Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libunistring: re-enable tests w/musl, update seems to have fixed #41638

Merged
merged 1 commit into from Jun 7, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 7, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libunistring

Partial log (click to expand)

/nix/store/adxwkvvvydfpl7r6zag62698441k87jn-libunistring-0.9.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libunistring

Partial log (click to expand)

/nix/store/59hdzi939fjw32yzblfz8jicyz3cnr9n-libunistring-0.9.9

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libunistring

Partial log (click to expand)

/nix/store/l6bvjfypcl0512vbdpqyh211arjz7cib-libunistring-0.9.9

@dtzWill
Copy link
Member Author

dtzWill commented Jun 7, 2018

Reverting the update causes test failures, so pretty sure this is good :).

@dtzWill dtzWill merged commit d8bf4d3 into NixOS:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants