Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: include requirements of dependencies #41080

Merged
merged 4 commits into from May 28, 2018
Merged

home-assistant: include requirements of dependencies #41080

merged 4 commits into from May 28, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented May 25, 2018 •
edited

Motivation for this change

closes #41028

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
Things left to do
  • deal with URL requirements (copy code from old script)
  • check how this impacts evaluation time
  • find a way to only include real components (e.g., zwave.workaround should not be included)
  • posibly remove some packages from propagatedBuildInputs
  • update description at the top of parse-requirements.py

Help is very welcome!

cc @peterhoeg @FRidh

@dotlambda dotlambda changed the title home-assistant: add requirements of dependencies home-assistant: include requirements of dependencies May 25, 2018
@dotlambda dotlambda force-pushed the home-assistant-recursive-reqs branch from fc85980 to b1aa2b7 Compare May 25, 2018 15:31
@peterhoeg
Copy link
Member

Very nice!

@dotlambda
Copy link
Member Author

@peterhoeg Do you have a idea how to get rid of something like zwave.workaround?
For example, we can not rely on each component having one of setup, async_setup, setup_platform or async_setup_platform.

@dotlambda
Copy link
Member Author

@peterhoeg I think I'm done with this. Feel free to work on the remaining points or merge.

@peterhoeg
Copy link
Member

I haven't tried it out, but it looks good to me. LGTM!

@peterhoeg peterhoeg merged commit b94e1f1 into NixOS:master May 28, 2018
@dotlambda dotlambda deleted the home-assistant-recursive-reqs branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

home-assistant fails to load when component doesn't have dependencies
3 participants
@dotlambda @peterhoeg @GrahamcOfBorg