Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procps-ng: 3.3.13 -> 3.3.15 #41082

Closed
wants to merge 1 commit into from
Closed

procps-ng: 3.3.13 -> 3.3.15 #41082

wants to merge 1 commit into from

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented May 25, 2018 •
edited

I can't "Tested compilation of all pkgs that depend on this change" because directly or indirectly over 1700 packages depend on this.

The patches are not necessary anymore.
Both problems were fixed in
https://gitlab.com/procps-ng/procps/commit/5576c8e4380badf262d3ee9af84404d24aae5a34

Motivation for this change

Update package to a newer version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Arch Linux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@JohnAZoidberg JohnAZoidberg changed the title WIP procps-ng: 3.3.13 -> 3.3.15 procps-ng: 3.3.13 -> 3.3.15 May 25, 2018
@xeji
Copy link
Contributor

xeji commented May 26, 2018

Please rebase this PR on the staging branch since it causes a mass rebuild. staging has procps-ng 3.3.14, so you'll need to modify your change to bump 3.3.14 -> 3.3.15.

@xeji
Copy link
Contributor

xeji commented May 28, 2018 •
edited

in the meantime master has been bumped to 3.3.14 as well, which causes the merge conflict

@dtzWill
Copy link
Member

dtzWill commented May 29, 2018

(apologies for my role in creating master/staging conflicts!)

@veprbl
Copy link
Member

veprbl commented May 31, 2018

https://nvd.nist.gov/vuln/detail/CVE-2018-1124
we are still 3.3.14 https://github.com/nixos/nixpkgs/blob/master/pkgs/os-specific/linux/procps-ng/default.nix

@xeji xeji mentioned this pull request May 31, 2018
Merged
8 tasks
@xeji
Copy link
Contributor

xeji commented May 31, 2018

I rebased this on staging in #41324 so we can get it merged.

orivej pushed a commit that referenced this pull request Jun 1, 2018
@xeji @orivej
procps-ng: 3.3.14 -> 3.3.15 (#41324)
f96c5ef 
https://nvd.nist.gov/vuln/detail/CVE-2018-1124

Closes #41082
@xeji
Copy link
Contributor

xeji commented Jun 1, 2018

closing in favor of #41324

@xeji xeji closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnAZoidberg @xeji @dtzWill @veprbl @GrahamcOfBorg