Best to just unbreak Darwin now. We can improve the condition later.

Yeah.

Wait what 😮. This condition makes completely no sense to me, can you, please, elaborate? 😕

This appears to be a macOS-only thing, so why is it !buildPlatform.isDarwin? Why does the version of ghc matter? I guess, my question can be summed up as “Why not simply buildPlatform.isDarwin?”

I guess I just don’t understand what was the original issue.
Current condition triggers on Linux always (??? I suppose this option does nothing there and even $p/Library probably never exists on Linux) and on Darwin with recent versions of GHC. So if the issue was about older versions of GHC (actually, Cabal, I suppose, as this is a Cabal flag?), then shouldn’t the condition be buildPlatform.isDarwin && versionAtLeast nativeGhc.version "8.0"?
@Ericson2314

@kirelagin This is specifically for cross compiling, the flags where added for linux->darwin and this fixes native darwin.

Why not hostPlatform.isDarwin && versionAtLeast nativeGhc.version "8.0" then?

Do you mean !hostPlatform.isDarwin or targetPlatform.isDarwin?

the flags where added for linux->darwin and this fixes native darwin

Again, the problem probably is that I do not understand the original issue. How stopping to include frameworks in certain cases can help with a cross-compilation to Darwin, when Darwin is exactly where these frameworks are needed?

I see how this could fix Darwin -> Linux compilation if buildHost libraries were included and the linker tried then to link a Linux binary to Darwin frameworks.
I now see that those frameworks are needed for host only, so, then, I think the condition should be hostPlatform.isDarwin, because we want to link with macOS frameworks when we are building a binary for it, regardless of the build platform (and of the target platform, I think).

@kirelagin Yes the condition is weird AF. I was gonna make it unconditional with the understanding that it would have no effect on Linux anyways. But then it failed with the Canal that came with GHC 8 on Darwin for unknown reasons. I think that was Cabal 1.24 and I tried the flag on Linux and it was recognized! So I have no idea what's going on.