python2Packages.supervisor: 3.1.4 -> 3.3.4 #41085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is going to have the same problem of python env var leaks to sub-processes right @FRidh ? |
dotlambda
requested changes
May 25, 2018
| sha256 = "0wp62z9xprvz2krg02xnbwcnq6pxfq3byd8cxx8c2d8xznih28i1"; | ||
| }; | ||
|
|
||
| buildInputs = [ mock ]; |
| description = "A system for controlling process state under UNIX"; | ||
| homepage = http://supervisord.org/; | ||
| maintainers = with lib.maintainers; [ zimbatm ]; | ||
| }; |
There was a problem hiding this comment.
license = lib.licenses.free; # http://www.repoze.org/LICENSE.txt
|
@dotlambda thanks, fixed. learned about checkInputs today. @GrahamcOfBorg build python2Packages.supervisor |
|
Success on x86_64-darwin (full log) Attempted: python2Packages.supervisor Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python2Packages.supervisor Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python2Packages.supervisor Partial log (click to expand)
|
dotlambda
approved these changes
May 25, 2018
|
@zimbatm what are you specifically referring to? |
|
@FRidh nevermind, the python wrapper doesn't set the python lib path through an environment variable anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package upgrade.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)