Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adobe_flex_sdk: 4.0.0.14159 -> apache-flex-sdk: 4.16.1 #41257

Merged
merged 1 commit into from Jun 2, 2018
Merged

adobe_flex_sdk: 4.0.0.14159 -> apache-flex-sdk: 4.16.1 #41257

merged 1 commit into from Jun 2, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented May 30, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed Jun 1, 2018
View reviewed changes
pkgs/development/compilers/apache-flex-sdk/default.nix Outdated
for i in $t/bin/*; do
b="$(basename "$i")";
cat > "$out/bin/$b" << EOF
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extra shell scripts aren't really necessary. Just use symlinks instead.

pkgs/top-level/all-packages.nix Show resolved Hide resolved
@xeji
Copy link
Contributor

xeji commented Jun 1, 2018

I just built this locally. It turns out that jre is missing as a runtime dependency since most of the binaries call java. You can either patch all scripts to replace java with its full path in the nix store or wrap the programs calling it using makeWrapper.

@xeji
Copy link
Contributor

xeji commented Jun 2, 2018

@GrahamcOfBorg build apache-flex-sdk

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: apache-flex-sdk

Partial log (click to expand)

unpacking source archive /nix/store/f56fii2rd9lc5v8gh1l251nfprp9cv66-apache-flex-sdk-4.16.1-bin.tar.gz
source root is apache-flex-sdk-4.16.1-bin
setting SOURCE_DATE_EPOCH to timestamp 1510733747 of file apache-flex-sdk-4.16.1-bin/samples/themes/graphite/src/assets/flex_skins.swf
patching sources
configuring
no configure script, doing nothing
building
installing
post-installation fixup
/nix/store/lwxxjxcwkn3f42yhk5g8yvym0rvhr0iq-apache-flex-sdk-4.16.1

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: apache-flex-sdk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: apache-flex-sdk

Partial log (click to expand)

unpacking source archive /nix/store/f56fii2rd9lc5v8gh1l251nfprp9cv66-apache-flex-sdk-4.16.1-bin.tar.gz
source root is apache-flex-sdk-4.16.1-bin
setting SOURCE_DATE_EPOCH to timestamp 1510733747 of file apache-flex-sdk-4.16.1-bin/samples/themes/graphite/src/assets/flex_skins.swf
patching sources
configuring
no configure script, doing nothing
building
installing
post-installation fixup
/nix/store/nbc3c2l05j1il9z533j9a3s3c3cd70d2-apache-flex-sdk-4.16.1

@xeji xeji merged commit 9290905 into NixOS:master Jun 2, 2018
@dywedir dywedir deleted the apache-flex-sdk branch June 2, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @xeji @GrahamcOfBorg