openafs_1_8: Init at 1.8.0 (was: openafs: 1.6.22.3 -> 1.8.0) #41889

spacefrogg · 2018-06-12T14:50:39Z

Introduce new "server" output holding the server binaries
Adapt tsmbac.patch to new build environment
Adapt openafs server nixos module accordingly
Update upstream CellServDB: 2017-03-14 -> 2018-05-14

Motivation for this change

Update to new stable release.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

xeji · 2018-06-13T16:34:14Z

@GrahamcOfBorg build linuxPackages.openafs

GrahamcOfBorg · 2018-06-13T16:34:55Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.openafs

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13582:3:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13582:16:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
while evaluating 'buildLinux' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13885:16, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13885:23:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:48:1

GrahamcOfBorg · 2018-06-13T16:37:41Z

Failure on aarch64-linux (full log)

Attempted: linuxPackages.openafs

Partial log (click to expand)

checking for ranlib... (cached) ranlib
checking for bison... bison -y
checking if lex is flex... yes
checking whether byte order is known at compile time... yes
checking whether byte ordering is bigendian... no
checking whether printf understands the %z length modifier... yes
checking your OS... linux
checking your AFS sysname... configure: error: An AFS sysname is required
builder for '/nix/store/qfndd5zfy580gnnczq9np3xv7zh0hdqn-openafs-1.8.0-4.14.49.drv' failed with exit code 1
error: build of '/nix/store/qfndd5zfy580gnnczq9np3xv7zh0hdqn-openafs-1.8.0-4.14.49.drv' failed

GrahamcOfBorg · 2018-06-13T17:04:07Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.openafs

Partial log (click to expand)

make[2]: Leaving directory '/build/openafs-1.8.0'
make[1]: Leaving directory '/build/openafs-1.8.0'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wrldnqjfx7va11pwfj1vk7vzxzwavsjl-openafs-1.8.0-4.14.49
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wrldnqjfx7va11pwfj1vk7vzxzwavsjl-openafs-1.8.0-4.14.49/lib
patching script interpreter paths in /nix/store/wrldnqjfx7va11pwfj1vk7vzxzwavsjl-openafs-1.8.0-4.14.49
checking for references to /build in /nix/store/wrldnqjfx7va11pwfj1vk7vzxzwavsjl-openafs-1.8.0-4.14.49...
/nix/store/wrldnqjfx7va11pwfj1vk7vzxzwavsjl-openafs-1.8.0-4.14.49

xeji · 2018-06-13T17:49:51Z

According to Hydra logs this never built on aarch64, although upstream seems to support ARM.

Please mark the package as broken on aarch64: meta.broken = stdenv.isAarch64;

spacefrogg · 2018-06-18T18:06:18Z

@GrahamcOfBorg build linuxPackages.openafs

... looks like I don't have the mojo...

xeji · 2018-06-18T19:37:46Z

@GrahamcOfBorg build linuxPackages.openafs

GrahamcOfBorg · 2018-06-18T19:38:26Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.openafs

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13588:3:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13588:16:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
while evaluating 'buildLinux' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13891:16, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:113:35, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13891:23:
while evaluating 'makeOverridable' at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:72:24, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:117:8:
while evaluating anonymous function at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:74:12:
assertion failed at /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel/generic.nix:48:1

GrahamcOfBorg · 2018-06-18T19:39:29Z

Failure on aarch64-linux (full log)

Attempted: linuxPackages.openafs

Partial log (click to expand)

checking for ranlib... (cached) ranlib
checking for bison... bison -y
checking if lex is flex... yes
checking whether byte order is known at compile time... yes
checking whether byte ordering is bigendian... no
checking whether printf understands the %z length modifier... yes
checking your OS... linux
checking your AFS sysname... configure: error: An AFS sysname is required
builder for '/nix/store/y4v8vky78iynmd7wphdhhx4rgw60m1qv-openafs-1.8.0-4.14.50.drv' failed with exit code 1
error: build of '/nix/store/y4v8vky78iynmd7wphdhhx4rgw60m1qv-openafs-1.8.0-4.14.50.drv' failed

GrahamcOfBorg · 2018-06-18T19:44:42Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.openafs

Partial log (click to expand)

make[2]: Leaving directory '/build/openafs-1.8.0'
make[1]: Leaving directory '/build/openafs-1.8.0'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m7nv7x2l7frz6vnlc2cffi6bgjxxzijq-openafs-1.8.0-4.14.50
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m7nv7x2l7frz6vnlc2cffi6bgjxxzijq-openafs-1.8.0-4.14.50/lib
patching script interpreter paths in /nix/store/m7nv7x2l7frz6vnlc2cffi6bgjxxzijq-openafs-1.8.0-4.14.50
checking for references to /build in /nix/store/m7nv7x2l7frz6vnlc2cffi6bgjxxzijq-openafs-1.8.0-4.14.50...
/nix/store/m7nv7x2l7frz6vnlc2cffi6bgjxxzijq-openafs-1.8.0-4.14.50

xeji · 2018-06-18T19:48:10Z

still broken on aarch64

spacefrogg · 2018-06-26T16:08:16Z

I changed the direction of this PR. The packages openafs and openafs_1_8 are both maintained for a while to allow for a smooth transition (especially for servers) from OpenAFS 1.6 to 1.8.

I introduced nixos options for package selection to further smoothen the transition.

spacefrogg · 2018-06-29T12:47:09Z

I just noticed a bug in the new openafs release. Please don't merge, yet.

- Introduce new "server" output holding the server binaries - Adapt tsmbac.patch to new build environment - Adapt openafs nixos server module accordingly - Update upstream CellServDB: 2017-03-14 -> 2018-05-14 - Introduce package attributes to refer to the openafs packages to use for server, programs and kernel module

spacefrogg · 2018-06-29T15:20:40Z

The bug is fixed. PR is ready to be merged.

xeji · 2018-06-29T22:09:05Z

@GrahamcOfBorg build linuxPackages.openafs_1_8

GrahamcOfBorg · 2018-06-29T22:09:31Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxPackages.openafs_1_8

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:13688:3:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:13688:16:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:74:12:
while evaluating 'buildLinux' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:14004:16, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix�[0m:5:1:
while evaluating 'callPackageWith' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:113:35, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix�[0m:14004:23:
while evaluating 'makeOverridable' at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:72:24, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix�[0m:1:1, called from �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix�[0m:74:12:
assertion failed at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix�[0m:48:1

GrahamcOfBorg · 2018-06-29T22:09:41Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages.openafs_1_8

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

xeji · 2018-06-29T22:17:37Z

@GrahamcOfBorg build openafs_1_8

GrahamcOfBorg · 2018-06-29T22:17:47Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openafs_1_8

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-29T22:25:24Z

Success on x86_64-linux (full log)

Attempted: linuxPackages.openafs_1_8

Partial log (click to expand)

make[2]: Leaving directory '/build/openafs-1.8.0'
make[1]: Leaving directory '/build/openafs-1.8.0'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9h903zcpa6an1651dirxs54h521lk595-openafs-1.8.0-4.14.52
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9h903zcpa6an1651dirxs54h521lk595-openafs-1.8.0-4.14.52/lib
patching script interpreter paths in /nix/store/9h903zcpa6an1651dirxs54h521lk595-openafs-1.8.0-4.14.52
checking for references to /build in /nix/store/9h903zcpa6an1651dirxs54h521lk595-openafs-1.8.0-4.14.52...
/nix/store/9h903zcpa6an1651dirxs54h521lk595-openafs-1.8.0-4.14.52

GrahamcOfBorg · 2018-06-29T22:25:56Z

Failure on aarch64-linux (full log)

Attempted: openafs_1_8

Partial log (click to expand)

checking for ranlib... (cached) ranlib
checking for bison... bison -y
checking if lex is flex... yes
checking whether byte order is known at compile time... yes
checking whether byte ordering is bigendian... no
checking whether printf understands the %z length modifier... yes
checking your OS... linux
checking your AFS sysname... configure: error: An AFS sysname is required
builder for '/nix/store/2fw88qhmp3fvppr7kqzx8dmgpmz3va7i-openafs-1.8.0.drv' failed with exit code 1
error: build of '/nix/store/2fw88qhmp3fvppr7kqzx8dmgpmz3va7i-openafs-1.8.0.drv' failed

GrahamcOfBorg · 2018-06-29T22:29:23Z

Success on x86_64-linux (full log)

Attempted: openafs_1_8

Partial log (click to expand)

shrinking /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec/openafs/dasalvager
shrinking /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec/openafs/salvageserver
shrinking /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec/openafs/dafileserver
shrinking /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec/openafs/davolserver
shrinking /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec/openafs/upserver
shrinking /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec/openafs/upclient
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server/libexec
patching script interpreter paths in /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server
checking for references to /build in /nix/store/4lczh0rw68wh8f8ipj30y96ar2zc88yw-openafs-1.8.0-server...

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Jun 12, 2018

spacefrogg force-pushed the openafs-1.8.0 branch from 03e4946 to c5504ed Compare June 18, 2018 17:54

spacefrogg force-pushed the openafs-1.8.0 branch 2 times, most recently from 76a927e to 66334ba Compare June 26, 2018 16:04

spacefrogg changed the title ~~openafs: 1.6.22.3 -> 1.8.0~~ openafs_1_8: Init at 1.8.0 (was: openafs: 1.6.22.3 -> 1.8.0) Jun 26, 2018

GrahamcOfBorg added the 8.has: package (new) label Jun 26, 2018

spacefrogg force-pushed the openafs-1.8.0 branch from 66334ba to d87217e Compare June 28, 2018 15:27

spacefrogg force-pushed the openafs-1.8.0 branch from d87217e to 35ebd3f Compare June 29, 2018 14:35

xeji merged commit 37c9992 into NixOS:master Jun 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openafs_1_8: Init at 1.8.0 (was: openafs: 1.6.22.3 -> 1.8.0) #41889

openafs_1_8: Init at 1.8.0 (was: openafs: 1.6.22.3 -> 1.8.0) #41889

spacefrogg commented Jun 12, 2018

xeji commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

xeji commented Jun 13, 2018

spacefrogg commented Jun 18, 2018 •

edited

xeji commented Jun 18, 2018

GrahamcOfBorg commented Jun 18, 2018

GrahamcOfBorg commented Jun 18, 2018

GrahamcOfBorg commented Jun 18, 2018

xeji commented Jun 18, 2018

spacefrogg commented Jun 26, 2018

spacefrogg commented Jun 29, 2018

spacefrogg commented Jun 29, 2018

xeji commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

xeji commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

openafs_1_8: Init at 1.8.0 (was: openafs: 1.6.22.3 -> 1.8.0) #41889

openafs_1_8: Init at 1.8.0 (was: openafs: 1.6.22.3 -> 1.8.0) #41889

Conversation

spacefrogg commented Jun 12, 2018

Motivation for this change

Things done

xeji commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

GrahamcOfBorg commented Jun 13, 2018

xeji commented Jun 13, 2018

spacefrogg commented Jun 18, 2018 • edited

xeji commented Jun 18, 2018

GrahamcOfBorg commented Jun 18, 2018

GrahamcOfBorg commented Jun 18, 2018

GrahamcOfBorg commented Jun 18, 2018

xeji commented Jun 18, 2018

spacefrogg commented Jun 26, 2018

spacefrogg commented Jun 29, 2018

spacefrogg commented Jun 29, 2018

xeji commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

xeji commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

spacefrogg commented Jun 18, 2018 •

edited