Fix: use Crystal::System::Random in Crystal::Hasher #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Random::Secure` in `prelude.cr` causes some load order issues when the crystal-random shard is required, and this prevents a program compilation (e.g. the crystal-random specs). The exact issue is unknown, but using `Crystal::System::Random` directly instead of `Random::Secure` (which merely delegates to `Crystal::System::Random`) fixes the compilation issue.
|
Can you paste the error you got with the load order? |
RX14
approved these changes
Jun 12, 2018
|
Perhaps add a comment about using |
|
@RX14 : just clone crystal-random, fix the $ crystal spec --verbose
Error in line 1: while requiring "prelude"
in /usr/share/crystal/src/prelude.cr:41: while requiring "hash"
require "hash"
^
in /usr/share/crystal/src/hash.cr:1: while requiring "crystal/hasher"
require "crystal/hasher"
^
in /usr/share/crystal/src/crystal/hasher.cr:85: undefined constant Random::Secure
Random::Secure.random_bytes(Slice.new(pointerof(@@seed).as(UInt8*), sizeof(typeof(@@seed))))
^~~~~~~~~~~~~~@straight-shoota we're inside the private |
|
Also, a |
Ah, I missed that, sorry. It's fine then. |
This was referenced Jun 12, 2018
bcardiff
approved these changes
Jun 13, 2018
wooster0
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Random::Secureinprelude.crcauses some load order issues when the crystal-random shard is required, and this prevents a program compilation (e.g. the crystal-random specs). The exact issue is unknown. Maybe it's related to adding more implementations of theRandommodule, required byRandom::Secure, and creating a kind of loop betweenHash->Crystal::Hasher->Random::Secure<->Randomthat the compiler can't satisfy.Using
Crystal::System::Randomdirectly instead ofRandom::Secure(which merely delegates toCrystal::System::Random) fixes the compilation issue. I'm not fond of that solution (or hack), but it works.