Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell generic-builder: Fix setup depends #41896

Merged
merged 1 commit into from Jun 13, 2018
Merged

haskell generic-builder: Fix setup depends #41896

merged 1 commit into from Jun 13, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

I was referring to the wrong package db in a few places. Thanks @ElvishJerricco for catching.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from peti as a code owner June 12, 2018 18:04
@Ericson2314
haskell generic-builder: Fix setup depends
eeeaab8 
I was referring to the wrong package db in a few places. Thanks
@ElvishJerricco for catching.
@Ericson2314
Copy link
Member Author

Made https://hydra.nixos.org/jobset/nixpkgs/ericson2314-haskell-updates to test

@ElvishJerricco ElvishJerricco mentioned this pull request Jun 13, 2018
Closed
@Ericson2314 Ericson2314 merged commit 089297a into NixOS:master Jun 13, 2018
@Ericson2314 Ericson2314 deleted the fix-setup-depends branch June 13, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @matthewbauer @GrahamcOfBorg