Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngspice: Fix regression due to missing X libs #41890

Merged
merged 1 commit into from Jun 13, 2018
Merged

ngspice: Fix regression due to missing X libs #41890

merged 1 commit into from Jun 13, 2018

Conversation

spacefrogg
Copy link
Contributor

Motivation for this change

Most of ngspice, esp. the ngspice binary, was not built due to missing X libraries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 13, 2018 •
edited

/cc maintainers @bgamari @viric @rongcuid
@GrahamcOfBorg build ngspice

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ngspice

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ngspice

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ngspice

Partial log (click to expand)

shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/digital.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/analog.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/xtradev.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/xtraevt.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/table.cm
gzipping man pages under /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib  /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/bin
patching script interpreter paths in /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28
checking for references to /build in /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ngspice

Partial log (click to expand)

shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/table.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/digital.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/xtraevt.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/spice2poly.cm
shrinking /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib/ngspice/xtradev.cm
gzipping man pages under /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/lib  /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28/bin
patching script interpreter paths in /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28
checking for references to /build in /nix/store/yllr15hmq4w21zpwxixsc99lhp8zkcw4-ngspice-28...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ngspice

Partial log (click to expand)

these derivations will be built:
  /nix/store/hc45aahfdnfjrxw55bv3f9kcn69kl0ii-ngspice-28.drv
waiting for locks or build slots...
/nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ngspice

Partial log (click to expand)

shrinking /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/lib/ngspice/analog.cm
shrinking /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/lib/ngspice/digital.cm
shrinking /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/lib/ngspice/spice2poly.cm
shrinking /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/bin/ngspice
shrinking /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/bin/cmpp
gzipping man pages under /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/lib  /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28/bin
patching script interpreter paths in /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28
checking for references to /build in /nix/store/d2ci5z4xi2i6khxggk7dacf4q7ypylna-ngspice-28...

@xeji xeji merged commit 0b475d3 into NixOS:master Jun 13, 2018
orivej added a commit that referenced this pull request Jun 13, 2018
@orivej
Merge branch 'master' into staging
8e61ad2 
* master: (33 commits)
  Revert "libxml2: add static output"
  yq: 2.5.0 -> 2.6.0 (#41926)
  yoshimi: 1.5.8 -> 1.5.8.2 (#41925)
  haskell generic-builder: Use separate setup db in more cases
  nixos/tests/morty: fix non-deterministic failure
  texlive: Fix 'match-parens' ruby dependency
  chromium: 67.0.3396.62 -> 67.0.3396.87
  ngspice: Fix regression due to missing X libs (#41890)
  mattermost-desktop: init at 4.1.1 (#40794)
  xcircuit: init at 3.9.73 (#41891)
  yarn: 1.7.0 -> 1.8.0 (#41895)
  Update default.nix (#41842)
  libxml2: add static output
  remarshal: supports darwin
  go-ethereum: 1.8.10 -> 1.8.11
  bazel: add darwin support
  llvm: use native cmake for libc++abi
  kicad-unstable: 2018-03-10 -> 2018-06-12
  cmake: Only apply application-services.patch with 3.11
  nixos/tinc: minor fixes
  ...
@spacefrogg spacefrogg deleted the ngspice-regression-fix branch June 13, 2018 16:55
@timor
Copy link
Member

timor commented Aug 16, 2018

@xeji Sorry if you are not the one responsible, but can/will this land in 18.03?

@xeji
Copy link
Contributor

xeji commented Aug 16, 2018

@timor I just tried cherry-picking this fix but by itself it doesn't seem to fix the package on 18.03, the ngspice binary still doesn't build.

A proper fix would need to incorporate some of the other changes made between 18.03 and master. I don't have time for that. Feel free to fix the package on 18.03 and open a pull request based on the release-18.03 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spacefrogg @xeji @GrahamcOfBorg @timor