New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python package set: major updates #41894
Conversation
57523cb
to
d354cb2
Compare
2419510
to
b25a1f1
Compare
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: python Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
@@ -11,7 +11,7 @@ | |||
buildPythonPackage rec { | |||
pname = "ftfy"; | |||
|
|||
version = "4.4.3"; | |||
version = "5.4.0"; | |||
# ftfy v5 only supports python3. Since at the moment the only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the comment still apply?
@@ -4,13 +4,13 @@ | |||
buildPythonPackage rec { | |||
pname = "netCDF4"; | |||
name = "${pname}-${version}"; | |||
version = "1.3.1"; | |||
version = "1.4.0"; | |||
|
|||
disabled = isPyPy; | |||
|
|||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchPypi
Failure on x86_64-darwin (full log) Attempted: python Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently rpy2 2.9.x doesn't support python2 anymore:
rpy2 is no longer supporting Python < 3. Consider using an older rpy2 release when using an older Python release.
So we should probably keep a 2.8.x version around. And mark 2.9.x as python3 only.
@@ -24,11 +24,11 @@ | |||
|
|||
buildPythonPackage rec { | |||
pname = "notebook"; | |||
version = "5.4.1"; | |||
version = "5.5.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the build:
ERROR: Failure: ImportError (No module named selenium.webdriver.common.by)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding selenium
to checkInputs
fixes it (selenium changelog: https://github.com/jupyter/notebook/blob/master/docs/source/changelog.rst).
Edit: I accidentally tested the downgraded package. It does fix the selenium import error, but it still doesn't build:
ERROR: notebook.tests.selenium.test_dashboard_nav.test_items
----------------------------------------------------------------------
Traceback (most recent call last):
File "/nix/store/n6m5xs9riz93p8np0ab131hjdmgpi028-python3.6-nose-1.3.7/lib/python3.6/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
TypeError: test_items() missing 1 required positional argument: 'authenticated_browser'
-------------------- >> begin captured logging << --------------------
NotebookApp: INFO: Shutting down 0 kernels
--------------------- >> end captured logging << ---------------------
and various other errors complaining about that same positional argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should test selenium at all - those tests are too brittle in my experience, the whole test suite could be deleted before building: https://github.com/jupyter/notebook/tree/ebe01762eb3e93b2c3f525eceb27ca6dd9611000/notebook/tests/selenium
Success on x86_64-darwin (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: aws-sam-cli, jrnl, pirate-get, python The following builds were skipped because they don't evaluate on x86_64-darwin: conan Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: aws-sam-cli, jrnl, pirate-get, python Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: jrnl, pirate-get, python Partial log (click to expand)
|
The "python-dateutil: 1.5 -> 2.7.3" commit 07679a9 broke
|
|
@FRidh You probably did not mean to bump the version in pkgs/development/python-modules/dateutil/1_5.nix either, right? |
@mbode Is this file used anywhere? |
@dotlambda I don't know, just randomly stumbled over it. I guess if it isn't, it should be deleted. |
Done in d7cce08. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)