Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/seahorse: require gnome3.dconf #41887

Merged
merged 1 commit into from Nov 21, 2018
Merged

nixos/seahorse: require gnome3.dconf #41887

merged 1 commit into from Nov 21, 2018

Conversation

gmarmstrong
Copy link
Contributor

@gmarmstrong gmarmstrong commented Jun 12, 2018 •
edited

Fix #41886.

Motivation for this change

Seahorse previously would not function (at least, not without GNOME installed).

Things done

Adds pkgs.gnome3.dconf to environment.systemPackages. Tested with the gnome3.nix test.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from jtojnar June 12, 2018 14:09
@Mic92
Copy link
Member

Mic92 commented Jun 12, 2018

I always though having a wrapper adding dconf as a module is enough.

GIO_EXTRA_MODULES='/nix/store/7vqsjsmkm0gi2xksa9jq1xy22540dx47-dconf-0.28.0-lib/lib/gio/modules

Now it seems that the dbus service is required too.
That would affect many other gnome applications too.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 12, 2018 •
edited

See also #30271, #39997

@matthewbauer
Copy link
Member

Yeah I remember this is breaking macOS - dbus is unavailable IIRC. I can't remember the app I hit this issue with though...

@gmarmstrong
Copy link
Contributor Author

gmarmstrong commented Jun 12, 2018 •
edited

@Mic92, do you mean that making this change would affect other GNOME apps, or just that this issue also affects other GNOME apps?

@matthewbauer, Seahorse is only available on platforms.linux.

@Mic92
Copy link
Member

Mic92 commented Jun 13, 2018 •
edited

@gmarmstrong I mean that potentially other Gnome applications might be broken outside of GNOME for the same reason.

@matthewbauer matthewbauer merged commit 75999d4 into NixOS:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gmarmstrong @Mic92 @jtojnar @matthewbauer @GrahamcOfBorg