Skip to content

9000 embedding tests broken+disabled #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enebo opened this issue Jun 10, 2014 · 5 comments
Closed

9000 embedding tests broken+disabled #1734

enebo opened this issue Jun 10, 2014 · 5 comments
Milestone
Non-Release

Comments

@enebo
Copy link
Member

enebo commented Jun 10, 2014

I had to disable many embedding tests BSF, JSR223, RedBridge. There are several things which need to be resolved before these can be reenabled:

  1. We have an incomplete JIT and definitely cannot FORCE
  2. compiled code in embedding APIs cache Node and not what IRBuilds
  3. live top-level scope sharing is broken (IR will replace the scope it pushes -- item 2 should be part of this fix)

Some more notes as I was looking at this. We have an IRTranslator which has an execute(). Instead of this (or in addition) probably want either a special *Method or some opaque structure which is the result of a build() method (could also be named compile()). The opaque structure could then have the execute of IRTranslator and an execute where we specify the live variable values.
@enebo enebo added this to the JRuby 9000 milestone Jun 10, 2014
@yokolet
Copy link
Member

yokolet commented Jun 10, 2014

(oh, no..)
To watch this issue, I'm writing. I'll look at, but maybe not now, sorry.

enebo added a commit that referenced this issue Jun 10, 2014
@enebo
Comment out some embedding tests until we can write proper IR-embeddi…
0751b13 
…ng abstraction: GH #1734
@enebo
Copy link
Member Author

enebo commented Jun 10, 2014

This is definitely not your fault. We just forgot about this type of usage. I will try and make an abstraction for this once I get the old runtime/compiler completely removed. You may not need to do anything at that point but obviously your help is always welcome :)

@yokolet
Copy link
Member

yokolet commented Jun 11, 2014

OK. But, at least, I think I should start looking at code so that I can help to fix embedding API.

@enebo
Copy link
Member Author

enebo commented Jun 11, 2014

Sure. Any help is appreciated. The other embedding activity I am hoping can happen for 9000 is to have blessed core object creation APIs (e.g. createHash()). I am not sure where and how these should be defined but it would be great if 99% of all native extensions, like Nokogiri, could be using only blessed, isolated, embedding APIs.

@enebo enebo modified the milestone: JRuby 9.0.0.0 Jul 14, 2015
@kares kares added this to the Non-Release milestone Jun 12, 2018
@kares
Copy link
Member

kares commented Jun 12, 2018

... and 3y later - let's 686a861 🔫

@kares kares closed this as completed Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
3 participants
@enebo @kares @yokolet