Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asc-key-to-qr-code-gif: init at 20180613 #41893

Merged
merged 1 commit into from Jun 18, 2018
Merged

asc-key-to-qr-code-gif: init at 20180613 #41893

merged 1 commit into from Jun 18, 2018

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 12, 2018 •
edited

Motivation for this change

NOTE No idea why I only had to run substituteInPlace on convert and not on e.g. qrencode.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ryantm
ryantm requested changes Jun 13, 2018
View reviewed changes
pkgs/tools/security/asc-key-to-qr-code-gif/default.nix Outdated

stdenv.mkDerivation rec {
name = "asc-key-to-qr-code-gif-${version}";
version = "e5d517b9fe230b9814458b84a9559358f9a492aa"; # no proper versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of a project like this with no releases, we typically use the date the commit was made. For example, if the revision was commited on Jun 11, 2017, we'd use 20170611 as the version. This would let us have increasing version numbers when we make updates to the package.

By the way, it looks like there were a lot more commits today.

@asymmetric
Copy link
Contributor Author

asymmetric commented Jun 13, 2018 •
edited

@ryantm any idea on why I only had to run substituteInPlace on convert and not on e.g. qrencode?

Also, are there more phases/steps I can disable? nix-build fetches gcc, patchelf and lots of other things, and I'm not sure why.

@asymmetric asymmetric changed the title asc-key-to-qr-code-gif: init at e5d517b9 asc-key-to-qr-code-gif: init at 20180613 Jun 13, 2018
@ryantm
Copy link
Member

ryantm commented Jun 13, 2018

@asymmetric How are you testing it? Maybe you already have qrencode on your path. Can you try running it with nix-shell --pure -p asc-key-to-qr-code-gif?

You could try using nix why-depends to see what's up with the dependencies.

You can control exactly which phases run by using the phases attribute: https://nixos.org/nixpkgs/manual/#ssec-controlling-phases

@asymmetric
Copy link
Contributor Author

You were right, it was using my local qrencode.

The nix-shell --pure -p asc-key-to-qr-code-gif failed with error: undefined variable 'asc-key-to-qr-code-gif' at (string):1:94, and AFAIK I can't pass a custom -f.

@ryantm
Copy link
Member

ryantm commented Jun 13, 2018

Yeah, the nix interface is so inconsistent :(. You can use -I nixpkgs=/path/to/nixpkgs with nix-shell.

@asymmetric
Copy link
Contributor Author

Cool! Tried it and it worked fine. Is this good to go? :)

@ryantm
Copy link
Member

ryantm commented Jun 13, 2018

@GrahamcOfBorg build asc-key-to-qr-code-gif

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: asc-key-to-qr-code-gif

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: asc-key-to-qr-code-gif

Partial log (click to expand)

source root is source
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/01dvfdzql1llsy240dp927bjgh08928r-asc-key-to-qr-code-gif-20180613
/nix/store/01dvfdzql1llsy240dp927bjgh08928r-asc-key-to-qr-code-gif-20180613/bin/asc-to-gif.sh: interpreter directive changed from "/bin/bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/01dvfdzql1llsy240dp927bjgh08928r-asc-key-to-qr-code-gif-20180613...
/nix/store/01dvfdzql1llsy240dp927bjgh08928r-asc-key-to-qr-code-gif-20180613

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: asc-key-to-qr-code-gif

Partial log (click to expand)

patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
installing
post-installation fixup
patching script interpreter paths in /nix/store/5y2lw1vbvx7gbgs8sv6w2y30nkykfv91-asc-key-to-qr-code-gif-20180613
/nix/store/5y2lw1vbvx7gbgs8sv6w2y30nkykfv91-asc-key-to-qr-code-gif-20180613/bin/asc-to-gif.sh: interpreter directive changed from "/bin/bash" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/5y2lw1vbvx7gbgs8sv6w2y30nkykfv91-asc-key-to-qr-code-gif-20180613...
/nix/store/5y2lw1vbvx7gbgs8sv6w2y30nkykfv91-asc-key-to-qr-code-gif-20180613

@ryantm
Copy link
Member

ryantm commented Jun 14, 2018

This looks good to me to merge in.

@xeji xeji merged commit 8807039 into NixOS:master Jun 18, 2018
@asymmetric asymmetric deleted the asymmetric/asc-qr branch June 18, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asymmetric @ryantm @GrahamcOfBorg @xeji