Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pykerberos, requests-kerberos, exchangelib #41892

Merged
merged 3 commits into from Jul 28, 2018
Merged

add pykerberos, requests-kerberos, exchangelib #41892

merged 3 commits into from Jul 28, 2018

Conversation

catern
Copy link
Contributor

@catern catern commented Jun 12, 2018

Motivation for this change

I want these packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@catern catern requested a review from FRidh as a code owner June 12, 2018 16:56
FRidh
FRidh requested changes Jun 12, 2018
View reviewed changes
pkgs/development/python-modules/exchangelib/default.nix Outdated
buildPythonPackage rec {
pname = "exchangelib";
version = "1.11.4";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed.

pkgs/development/python-modules/pykerberos/default.nix Outdated
buildPythonPackage rec {
pname = "pykerberos";
version = "1.2.1";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed.

pkgs/development/python-modules/requests-kerberos/default.nix Outdated
buildPythonPackage rec {
pname = "requests-kerberos";
version = "0.12.0";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed.

@FRidh
Copy link
Member

FRidh commented Jun 12, 2018

@GrahamcOfBorg build pythonPackages.pykerberos pythonPackages.requests-pykerberos pythonPackages.exchangelib python3Packages.pykerberos python3Packages.requests-pykerberos python3Packages.exchangelib

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.pykerberos, python3Packages.pykerberos

The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.requests-pykerberos, pythonPackages.exchangelib, python3Packages.requests-pykerberos, python3Packages.exchangelib

Partial log (click to expand)

writing manifest file 'pykerberos.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-aarch64-3.6/kerberos.cpython-36m-aarch64-linux-gnu.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/garxvnz9mjdakhpq2np2bi94l1mrsp7q-python2.7-pykerberos-1.2.1
/nix/store/mazzkl0br0jx93nlca4bf3zix5yndysi-python3.6-pykerberos-1.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.pykerberos, python3Packages.pykerberos

The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.requests-pykerberos, pythonPackages.exchangelib, python3Packages.requests-pykerberos, python3Packages.exchangelib

Partial log (click to expand)

writing manifest file 'pykerberos.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-x86_64-3.6/kerberos.cpython-36m-x86_64-linux-gnu.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/m3dp69a198rg3kj4kw6v0jcfdrv8jxmb-python2.7-pykerberos-1.2.1
/nix/store/gh4xr95rkzvflp59kdasnmin8l2xlvcc-python3.6-pykerberos-1.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.pykerberos, python3Packages.pykerberos

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.requests-pykerberos, pythonPackages.exchangelib, python3Packages.requests-pykerberos, python3Packages.exchangelib

Partial log (click to expand)

writing manifest file 'pykerberos.egg-info/SOURCES.txt'
running build_ext
copying build/lib.macosx-10.6-x86_64-3.6/kerberos.cpython-36m-darwin.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/85p2707zckc9rhh01w9yhllhawrbz0p1-python2.7-pykerberos-1.2.1
/nix/store/wi3maawlk2d7zkahghx2r34hg2x0alj5-python3.6-pykerberos-1.2.1

@catern catern force-pushed the exlib branch 2 times, most recently from 4a1e75f to 65e827b Compare June 12, 2018 20:10
@catern
Copy link
Contributor Author

catern commented Jun 21, 2018

Ping on this? I made the changes you asked for

FRidh
FRidh requested changes Jun 22, 2018
View reviewed changes
pkgs/development/python-modules/exchangelib/default.nix Outdated
}:

buildPythonPackage rec {
pname = "exchangelib";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space indentation

pkgs/development/python-modules/pykerberos/default.nix Outdated
{ stdenv, fetchPypi, buildPythonPackage, krb5 }:

buildPythonPackage rec {
pname = "pykerberos";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space indentation

pkgs/development/python-modules/requests-kerberos/default.nix Outdated
{ stdenv, fetchFromGitHub, buildPythonPackage, requests, pykerberos, mock }:

buildPythonPackage rec {
pname = "requests-kerberos";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space indentation

@catern
Copy link
Contributor Author

catern commented Jun 29, 2018

Ping, the formatting is fixed.

@catern
Copy link
Contributor Author

catern commented Jul 27, 2018

Ping? @FRidh

@FRidh
Copy link
Member

FRidh commented Jul 27, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@catern
Copy link
Contributor Author

catern commented Jul 28, 2018

There are no tests (besides one which tests against an existing Kerberos deployment), so I commented to that effect and set doCheck=false.

@FRidh FRidh merged commit 17a09eb into NixOS:master Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catern @FRidh @GrahamcOfBorg