Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 3.6.0 -> 3.6.1 #41130

Merged
merged 1 commit into from May 31, 2018
Merged

gitkraken: 3.6.0 -> 3.6.1 #41130

merged 1 commit into from May 31, 2018

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented May 27, 2018 •
edited

Motivation for this change

Upgrade gitkraken and refactor package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 27, 2018

cc @xNWDD

@xeji xeji merged commit e4ba5dc into NixOS:master May 31, 2018
@megheaiulian megheaiulian deleted the feature/gitkraken-3.6.1 branch June 2, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@megheaiulian @FRidh @GrahamcOfBorg @xeji