Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typora: fix gsettings error #41125

Merged
merged 1 commit into from May 28, 2018
Merged

typora: fix gsettings error #41125

merged 1 commit into from May 28, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented May 27, 2018 •
edited

Motivation for this change

Fix this well documented error preventing me from using file dialogs under KDE.
GLib-GIO-ERROR **: No GSettings schemas are installed on the system

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Notes

This was done very quickly so feel free to correct.

/cc @jensbin @xeji

@jensbin
Copy link
Contributor

jensbin commented May 27, 2018

Thanks @worldofpeace. My usual verification tests still work.

@xeji xeji merged commit 0e97d71 into NixOS:master May 28, 2018
@worldofpeace worldofpeace deleted the typora-fix branch May 28, 2018 10:08
@worldofpeace
Copy link
Contributor Author

@xeji I think this should be backported into 18.03 since an essential function has been restored under non gtk environments.

@xeji
Copy link
Contributor

xeji commented May 28, 2018

No problem, but please test this change with 18.03 first and confirm that it works.

@worldofpeace worldofpeace mentioned this pull request May 28, 2018
Merged
8 tasks
@worldofpeace worldofpeace mentioned this pull request Jun 26, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jensbin @xeji @GrahamcOfBorg