Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crystal: 0.24.1 -> 0.24.2 #41102

Merged
merged 1 commit into from May 26, 2018
Merged

Crystal: 0.24.1 -> 0.24.2 #41102

merged 1 commit into from May 26, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented May 26, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented May 26, 2018

@GrahamcOfBorg build crystal

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: crystal

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: crystal

Partial log (click to expand)

clang -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
./bin/crystal docs src/docs_main.cr
--: git: command not found
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
./bin/crystal build --no-debug -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
installing
post-installation fixup
gzipping man pages under /nix/store/nk9as9dhnmdbndf69ygwh3yyy40xsv30-crystal-0.24.2/share/man/
patching script interpreter paths in /nix/store/nk9as9dhnmdbndf69ygwh3yyy40xsv30-crystal-0.24.2
/nix/store/nk9as9dhnmdbndf69ygwh3yyy40xsv30-crystal-0.24.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: crystal

Partial log (click to expand)

shrinking /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2/lib/crystal/ext/sigfault.o
wrong ELF type
shrinking /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2/lib/crystal/llvm/ext/llvm_ext.o
wrong ELF type
gzipping man pages under /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2/share/man/
patching script interpreter paths in /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2
checking for references to /build in /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2...
wrong ELF type
wrong ELF type
/nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2

@grahamc grahamc merged commit d56aaa1 into NixOS:master May 26, 2018
@manveru manveru deleted the crystal-0.24.2 branch May 26, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @grahamc @GrahamcOfBorg