Skip to content

Fix types in AST switch statements #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix types in AST switch statements #1101

wants to merge 1 commit into from
+2 −3

Conversation

@isaachier
Copy link
Contributor

@isaachier isaachier commented Jun 12, 2018

There are more errors when I try to compile the AST, but at least these I could figure out and patch.

isaachier
isaachier commented Jun 12, 2018
View reviewed changes
std/zig/ast.zig
Op.NegationWrap,
Op.Try,
Op.Resume,
Op.UnwrapOptional,
Copy link
Contributor Author

@isaachier isaachier Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnwrapOptional seems to be an InfixOp now, not a PrefixOp.

@andrewrk andrewrk closed this in e1f56c9 Jun 13, 2018
@andrewrk
Copy link
Member

andrewrk commented Jun 13, 2018

Thanks for the PR. I added a test that calls the iterate() method on Node to catch these compile errors in the future.

@isaachier isaachier deleted the ast-switch-fixes branch June 13, 2018 15:55
@isaachier
Copy link
Contributor Author

isaachier commented Jun 13, 2018

Thanks. Glad this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

2 participants

@isaachier @andrewrk