Fix types in AST switch statements #1101

isaachier · 2018-06-12T20:59:07Z

There are more errors when I try to compile the AST, but at least these I could figure out and patch.

isaachier · 2018-06-12T20:59:53Z

std/zig/ast.zig

@@ -1561,8 +1561,7 @@ pub const Node = struct {
                Op.NegationWrap,
                Op.Try,
                Op.Resume,
-                Op.UnwrapOptional,


UnwrapOptional seems to be an InfixOp now, not a PrefixOp.

andrewrk · 2018-06-13T15:49:31Z

Thanks for the PR. I added a test that calls the iterate() method on Node to catch these compile errors in the future.

isaachier · 2018-06-13T15:55:43Z

Thanks. Glad this is fixed.

Fix types in AST switch statements

bffedd6

isaachier commented Jun 12, 2018

View reviewed changes

andrewrk closed this in e1f56c9 Jun 13, 2018

isaachier deleted the ast-switch-fixes branch June 13, 2018 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix types in AST switch statements #1101

Fix types in AST switch statements #1101

isaachier commented Jun 12, 2018

isaachier Jun 12, 2018

andrewrk commented Jun 13, 2018

isaachier commented Jun 13, 2018

Fix types in AST switch statements #1101

Fix types in AST switch statements #1101

Conversation

isaachier commented Jun 12, 2018

isaachier Jun 12, 2018

Choose a reason for hiding this comment

andrewrk commented Jun 13, 2018

isaachier commented Jun 13, 2018