Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: de25d2378c03
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d4b980f9af87
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on May 23, 2018

  1. Make remaining array-based variables non-volatile.

    The field-based variables we used by default during 9.1.x already
    were not volatile, which is the direction we want to move people.
    Volatility should be achieved through libraries like
    concurrent-ruby, or added to Ruby as a way to declare volatility
    at class definition time (attr_accessor :foo, volatile: true).
    
    The risk here seems small since 99% of variable accesses have
    already been nonvolatile for over a year, all major concurrency
    libraries are using the proper mechanisms that don't require
    instance variable volatility, and we have received no bugs where
    nonvolatile field-based variables were the cause.
    headius committed May 23, 2018
    Copy the full SHA
    389aa6a View commit details

Commits on Jun 12, 2018

  1. Merge pull request #5187 from headius/nonvolatile_ivars

    Non-volatile instance variables
    headius authored Jun 12, 2018
    Copy the full SHA
    d4b980f View commit details
Loading