New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bintools-wrapper: add support for frameworks #41914
Conversation
See https://github.com/NixOS/nixpkgs/pull/41911/files#diff-4746b81564a01e241a84d455575437e7R60 for example of somewhere where |
This is probably good to do! I am still trying to figure out why most of our stuff still works without these changes though. |
I think the compiler takes |
It's possible a lot of the packages' build definitions will call |
It's hard to test this because a lot of packages on darwin don't build successfully on |
You can rebase on |
Ping? I'm not a Darwin person; I just wonder what will make it to 18.09, and this seems safe enough for non-Darwin. |
I guess this is not necessary. But somebody knowing more should confirm. |
This isn't necessary per se, I wrote in the workaround in the Bazel derivation:
It just would be better to not need this, since bintools already handles libraries on its own, it should do the same for frameworks. I think the reason it's the only derivation that requires this is that it doesn't pass on compiler flags to the linker. |
Motivation for this change
Equivalent to what was done in 7bea6aa for cc-wrapper.
This adds the right
-F
flags toNIX_LDFLAGS
when adding frameworks to build inputs.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)