Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nexus: allow overriding the package #41909

Merged
merged 1 commit into from Jun 18, 2018
Merged

nixos/nexus: allow overriding the package #41909

merged 1 commit into from Jun 18, 2018

Conversation

aespinosa
Copy link
Contributor

Useful when pulling nixos-unstable in a stable NixOS installation.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Jun 13, 2018 •
edited

You probably need to read your configuration variable here for it to take any effect at all: https://github.com/NixOS/nixpkgs/pull/41909/files#diff-8f19529453146fe355d1c5289a69569cL115

And the following as well: https://github.com/NixOS/nixpkgs/pull/41909/files#diff-8f19529453146fe355d1c5289a69569cR64

All mentions of pkgs.nexus should probably be changed to cfg.package (except for the default value in the config that you added) for it to be consistent.

@aespinosa
nixos/nexus: allow overriding the package
783eb84 
Useful when pulling nixos-unstable in a stable NixOS installation.
@aespinosa
Copy link
Contributor Author

ah thanks for noticing. fixed now!

@nlewo
Copy link
Member

nlewo commented Jun 18, 2018

@GrahamcOfBorg test nexus

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.nexus

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nexus

Partial log (click to expand)

server: exit status 1
syncing
server: running command: sync
server: exit status 0
test script finished in 323.88s
cleaning up
killing server (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/kkzglfmzp9pav6bqvrqpkj6w5nccrnk9-vm-test-run-nexus

@nlewo nlewo merged commit 7a61c72 into NixOS:master Jun 18, 2018
@aespinosa aespinosa deleted the nexus-package branch June 19, 2018 15:31
@infinisil infinisil mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aespinosa @etu @nlewo @GrahamcOfBorg