raspberrypiWirelessFirmware: init #41327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dezgeg |
|
Sounds good. Though maybe I'd enable this only on ARM/aarch64 by default given that it's not really useful outside of Raspberry Pis. |
|
I can confirm wifi works perfectly on my RPI 3 with this firmware. |
matthewbauer
referenced
this pull request
Jun 22, 2018
Following legacy packing conventions, `isArm` was defined just for
32-bit ARM instruction set. This is confusing to non packagers though,
because Aarch64 is an ARM instruction set.
The official ARM overview for ARMv8[1] is surprisingly not confusing,
given the overall state of affairs for ARM naming conventions, and
offers us a solution. It divides the nomenclature into three levels:
```
ISA: ARMv8 {-A, -R, -M}
/ \
Mode: Aarch32 Aarch64
| / \
Encoding: A64 A32 T32
```
At the top is the overall v8 instruction set archicture. Second are the
two modes, defined by bitwidth but differing in other semantics too, and
buttom are the encodings, (hopefully?) isomorphic if they encode the
same mode.
The 32 bit encodings are mostly backwards compatible with previous
non-Thumb and Thumb encodings, and if so we can pun the mode names to
instead mean "sets of compatable or isomorphic encodings", and then
voilà we have nice names for 32-bit and 64-bit arm instruction sets
which do not use the word ARM so as to not confused either laymen or
experienced ARM packages.
[1]: https://developer.arm.com/products/architecture/a-profile
lopsided98
force-pushed
the
raspberrypi-wireless-firmware
branch
from
ee1e510
to
0ff9427
Compare
|
Oops, I just realized that I made the change you requested a few weeks ago, but never pushed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The builtin wifi and bluetooth radios do not currently work in NixOS on the RaspberryPi 3 and Raspberry Pi Zero W, because some firmware files are missing.
Things done
This PR adds a package containing the missing wifi and bluetooth firmware and adds it to
enableRedistributableFirmware. Some of the firmware files also exist infirmwareLinuxNonfree, but this package contains newer versions. Therefore, it must be placed later it the list to overwrite the files fromfirmwareLinuxNonfree.I have not actually tested bluetooth, but wifi now works out of the box with this PR.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)