Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php71: 7.1.17 -> 7.1.18 #41145

Merged
merged 1 commit into from May 28, 2018
Merged

php71: 7.1.17 -> 7.1.18 #41145

merged 1 commit into from May 28, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented May 27, 2018

Motivation for this change

Changelog: http://www.php.net/ChangeLog-7.php#7.1.18

It doesn't seem to be any security related changes this time. So I don't see much need for backporting. Backporting is common with the PHP packages. But this time it doesn't seem to be required 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18...
moving /nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18/sbin/* to /nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/i7a5xbi13fd2yxrlklfh83k5p1hvysbf-php-7.1.18-dev
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i7a5xbi13fd2yxrlklfh83k5p1hvysbf-php-7.1.18-dev
checking for references to /build in /nix/store/i7a5xbi13fd2yxrlklfh83k5p1hvysbf-php-7.1.18-dev...
/nix/store/5pjyd0dbb0hajcy0sjff8i81chakl051-php-7.1.18

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
/nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
/nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18...
moving /nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18/sbin/* to /nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/gx5kygjkw8mz8gllryvvdmm41hcqdg2w-php-7.1.18-dev
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gx5kygjkw8mz8gllryvvdmm41hcqdg2w-php-7.1.18-dev
checking for references to /build in /nix/store/gx5kygjkw8mz8gllryvvdmm41hcqdg2w-php-7.1.18-dev...
/nix/store/vpzb34fmfjqyvw4cmplcslgki7x3skf5-php-7.1.18

@xeji
Copy link
Contributor

xeji commented May 28, 2018

Let's check the darwin build:
@GrahamcOfBorg build php71

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/bin/peardev: interpreter directive changed from "/bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/bin/pecl: interpreter directive changed from "/bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
moving /nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/sbin/* to /nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18/bin
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/fb97cc373hbb0bsn4gpgzazjxg2056k0-php-7.1.18-dev
/nix/store/p92sg9sikshrz4wwrnzfsjpjkhcgz19x-php-7.1.18

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
/nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18...
moving /nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18/sbin/* to /nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/gsliifl4hff3awybwc0ldsgzlq8zlcrz-php-7.1.18-dev
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gsliifl4hff3awybwc0ldsgzlq8zlcrz-php-7.1.18-dev
checking for references to /build in /nix/store/gsliifl4hff3awybwc0ldsgzlq8zlcrz-php-7.1.18-dev...
/nix/store/gmc3hl84i91j8gv7jfz8i38yj6b4m59v-php-7.1.18

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
/nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
/nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/vnb8q2h7951gd551nm2vq2g6n8296g5b-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18...
moving /nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18/sbin/* to /nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/ki45axwlc5whcx9pxkrmaf03jw7ydp8m-php-7.1.18-dev
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ki45axwlc5whcx9pxkrmaf03jw7ydp8m-php-7.1.18-dev
checking for references to /build in /nix/store/ki45axwlc5whcx9pxkrmaf03jw7ydp8m-php-7.1.18-dev...
/nix/store/a1dd6slcybcxpn1jyzcizfyaacj8jkc2-php-7.1.18

@xeji xeji merged commit 463b9c9 into NixOS:master May 28, 2018
@etu etu deleted the php-upgrade branch May 28, 2018 18:04
xeji pushed a commit that referenced this pull request Jun 25, 2018
@etu @xeji
php71: 7.1.17 -> 7.1.18 (#41145)
18abd86 
Changelog: http://www.php.net/ChangeLog-7.php#7.1.18
(cherry picked from commit 463b9c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @xeji