Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring: Fixed compiling and version bump #41153

Merged
merged 2 commits into from May 29, 2018
Merged

spring: Fixed compiling and version bump #41153

merged 2 commits into from May 29, 2018

Conversation

baracoder
Copy link
Contributor

@baracoder baracoder commented May 27, 2018 •
edited

Motivation for this change

#39689 spring does not compile, can't build springlobby.
The fix is the same as here: #28748

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" <- used pr 41153 instead
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@baracoder
spring: Fix stdlib.h: No such file or directory
29950fe 
include_next fatal error: stdlib.h: No such file or directory
The fix is the same as here and works:
NixOS#28748

It seams to have to do with header paths.
@baracoder
spring: 103.0 -> 104.0
34c116a
@baracoder baracoder mentioned this pull request May 27, 2018
Closed
8 tasks
@xeji
Copy link
Contributor

xeji commented May 28, 2018

@GrahamcOfBorg build spring

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: spring

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: spring

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: spring

Partial log (click to expand)

shrinking /nix/store/fyxdhqjc2pnxa35r9g9qjprb2ddgkwq9-openjdk-8u172b11-jre/lib/openjdk/jre/lib/jexec
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fyxdhqjc2pnxa35r9g9qjprb2ddgkwq9-openjdk-8u172b11-jre/lib  /nix/store/fyxdhqjc2pnxa35r9g9qjprb2ddgkwq9-openjdk-8u172b11-jre/bin
patching script interpreter paths in /nix/store/fyxdhqjc2pnxa35r9g9qjprb2ddgkwq9-openjdk-8u172b11-jre
checking for references to /build in /nix/store/fyxdhqjc2pnxa35r9g9qjprb2ddgkwq9-openjdk-8u172b11-jre...
not an ELF executable
not an ELF executable
not an ELF executable
cannot build derivation '/nix/store/lhql8r560rfhn90sichldasp4myabq3m-spring-104.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lhql8r560rfhn90sichldasp4myabq3m-spring-104.0.drv' failed

@baracoder
Copy link
Contributor Author

Hm, why does it fail to build openjdk?
I can build and install it on two machines using

nix-env -f /home/bara/src/nixpkgs -i spring

@xeji
Copy link
Contributor

xeji commented May 29, 2018

No idea what went wrong there. But spring builds on my machine too, so let's merge this anyway.

@xeji xeji merged commit 094753c into NixOS:master May 29, 2018
@baracoder baracoder deleted the 39689-spring-broken branch September 3, 2018 12:47
@JohnAZoidberg JohnAZoidberg mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baracoder @xeji @GrahamcOfBorg