treewide: fix derivation names #41162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build altcoins.mist infamousPlugins swh-lv2 manuskript neovim-remote |
|
@GrahamcOfBorg build wxhexeditor yi exrtools gnuclad cura-lulzbot nix-tour xrandr-invert-colors |
|
Success on x86_64-darwin (full log) Attempted: neovim-remote The following builds were skipped because they don't evaluate on x86_64-darwin: altcoins.mist, infamousPlugins, swh-lv2, manuskript Partial log (click to expand)
|
|
@GrahamcOfBorg build uzbl coyim salut_a_toi weechat gwyddion ripser |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: wxhexeditor, yi, exrtools, gnuclad, cura-lulzbot, nix-tour, xrandr-invert-colors Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: weechat The following builds were skipped because they don't evaluate on x86_64-darwin: uzbl, coyim, salut_a_toi, gwyddion, ripser Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: wxhexeditor, exrtools, gnuclad, nix-tour, xrandr-invert-colors The following builds were skipped because they don't evaluate on x86_64-linux: yi, cura-lulzbot Partial log (click to expand)
|
veprbl
reviewed
May 28, 2018
| @@ -1,11 +1,12 @@ | |||
| { stdenv, zlib, fetchFromGitHub, python3Packages }: | |||
|
|
|||
| python3Packages.buildPythonApplication rec { | |||
| name = "manuskript"; | |||
| pname = "manuskript"; | |||
| name = "${pname}-${version}"; | |||
There was a problem hiding this comment.
Like with buildPythonPackage you don't need to define name here.
|
Success on x86_64-linux (full log) Attempted: coyim, salut_a_toi, weechat, gwyddion, ripser The following builds were skipped because they don't evaluate on x86_64-linux: uzbl Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: wxhexeditor, exrtools, gnuclad, nix-tour, xrandr-invert-colors The following builds were skipped because they don't evaluate on aarch64-linux: yi, cura-lulzbot Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: altcoins.mist, infamousPlugins, manuskript, neovim-remote The following builds were skipped because they don't evaluate on x86_64-linux: swh-lv2 Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: coyim, salut_a_toi, weechat, gwyddion, ripser The following builds were skipped because they don't evaluate on aarch64-linux: uzbl Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: infamousPlugins, manuskript, neovim-remote The following builds were skipped because they don't evaluate on aarch64-linux: altcoins.mist, swh-lv2 Partial log (click to expand)
|
FRidh
approved these changes
May 28, 2018
| in | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "simgrid-${version}"; | ||
| version = "3.17"; | ||
| version = "3.19.1"; |
There was a problem hiding this comment.
Yes, sorry for not mentioning that in the PR text it used to be more clear before I fixed the merge conflicts with master. I'll move this into it's own PR.
|
I moved the simgrid version bump to its own PR. #41178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
all these packages were being excluded from repology because their derivation names could not be parsed.
Things done