Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: gnome2 cleanup #41155

Merged
merged 2 commits into from May 29, 2018
Merged

wire-desktop: gnome2 cleanup #41155

merged 2 commits into from May 29, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Removed/updated gnome2 references (Part of #39976)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 28, 2018
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 29, 2018
@xeji
Copy link
Contributor

xeji commented May 29, 2018

@GrahamcOfBorg build wire-desktop

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: wire-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wire-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wire-desktop

Partial log (click to expand)

  /nix/store/b7l1w12zkzhnpkxiiv6fw8hjs7g6ys2j-libnotify-0.7.7
  /nix/store/d06dblmgmj6ag0xd8nn3pdlg3g2ingb0-wire-desktop.desktop
  /nix/store/mix13v18g4ni8x35w5sgsz9f12yq688z-wire_3.0.2816_amd64.deb
copying path '/nix/store/d06dblmgmj6ag0xd8nn3pdlg3g2ingb0-wire-desktop.desktop' from 'https://cache.nixos.org'...
copying path '/nix/store/mix13v18g4ni8x35w5sgsz9f12yq688z-wire_3.0.2816_amd64.deb' from 'https://cache.nixos.org'...
copying path '/nix/store/b7l1w12zkzhnpkxiiv6fw8hjs7g6ys2j-libnotify-0.7.7' from 'https://cache.nixos.org'...
building '/nix/store/in5rkpzf1v16wpyv3zpgqppijikl9ypv-wire-desktop-3.0.2816.drv'...
unpacking sources
installing
/nix/store/hcv20rc1acjxjhzbhbq889w87s4jf4pq-wire-desktop-3.0.2816

@xeji xeji merged commit e25e9d6 into NixOS:master May 29, 2018
orivej added a commit that referenced this pull request May 30, 2018
@orivej
Merge branch 'master' into staging
3576d47 
* master: (30 commits)
  bitlbee: fix build
  git: 2.17.0 -> 2.17.1
  sc-controller: 0.4.2 -> 0.4.3
  zeroc-ice: fix parallel building
  pythonPackages.bsddb3: fix build after 0fd461d
  haskellPackages.hlibgit2: fix build after #28029
  gdk-pixbuf: patch library rpath references on darwin
  virtualbox: fix build after #28029
  GHCJS darwin fixes (#41120)
  neovim-remote: 1.8.6 -> 2.0.5
  messenger-for-desktop: remove (#41224)
  typora: gnome2 cleanup (#41167)
  discord: gnome2 cleanup (#41174)
  skypeforlinux: gnome2 cleanup (#41176)
  wire-desktop: gnome2 cleanup (#41155)
  hyper: gnome2 cleanup (#41170)
  drone: 0.5 -> 0.8.5 (#41200)
  racket: use proper uname, allow for unix sockets
  kytea: fix build after #28029
  yoda: fix build after #28029
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @xeji @GrahamcOfBorg @FRidh