Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: gnome2 cleanup #41156

Merged
merged 1 commit into from May 28, 2018
Merged

signal-desktop: gnome2 cleanup #41156

merged 1 commit into from May 28, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Removed/updated gnome2 references (Part of #39976)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 28, 2018
@xeji
Copy link
Contributor

xeji commented May 28, 2018

@GrahamcOfBorg build signal-desktop

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: signal-desktop

Partial log (click to expand)

  /nix/store/5bvxg06wfz1vczzllqxy1hki2hl061qh-gconf-3.2.6
  /nix/store/89bqw5bqbmmab49gikrgfz4ddyw2i9m2-dpkg-1.19.0.5
  /nix/store/qhsv58mfxi8bqdi26753fmq4ppq56503-signal-desktop_1.11.0_amd64.deb
copying path '/nix/store/qhsv58mfxi8bqdi26753fmq4ppq56503-signal-desktop_1.11.0_amd64.deb' from 'https://cache.nixos.org'...
copying path '/nix/store/89bqw5bqbmmab49gikrgfz4ddyw2i9m2-dpkg-1.19.0.5' from 'https://cache.nixos.org'...
copying path '/nix/store/5bvxg06wfz1vczzllqxy1hki2hl061qh-gconf-3.2.6' from 'https://cache.nixos.org'...
building '/nix/store/ibvnbd8h10v3c6127qgk2nwq6nkgxfhh-signal-desktop-1.11.0.drv'...
unpacking sources
installing
/nix/store/0rxqx810n1j9ccvjmmnv2ng9ggipldpd-signal-desktop-1.11.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit e1b501a into NixOS:master May 28, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@worldofpeace worldofpeace deleted the signal-desktop-nognome2 branch May 28, 2018 10:54
primeos pushed a commit to primeos/nixpkgs that referenced this pull request Jul 17, 2018
@worldofpeace @primeos
signal-desktop: gnome2 cleanup (NixOS#41156)
5d27cfc 
(cherry picked from commit e1b501a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @xeji @GrahamcOfBorg @FRidh