Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

celf: init at 2013-07-25 #41141

Merged
merged 1 commit into from May 28, 2018
Merged

celf: init at 2013-07-25 #41141

merged 1 commit into from May 28, 2018

Conversation

bcdarwin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed May 28, 2018
View reviewed changes
pkgs/applications/science/logic/celf/default.nix Outdated
sha256 = "0slrwcxglp0sdbp6wr65cdkl5wcap2i0fqxbwqfi1q3cpb6ph6hq";
};

nativeBuildInputs = [ ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be omitted.

pkgs/applications/science/logic/celf/default.nix Outdated
./.mkexec ${smlnj}/bin/sml $out/bin celf
'';

meta = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you write meta = with stdenv.lib; { here, you don't have to repeat stdenv.lib. 3 times below.

@bcdarwin
Copy link
Member Author

@xeji -- both fixed.

@xeji
Copy link
Contributor

xeji commented May 28, 2018

@GrahamcOfBorg build celf

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: celf

Partial log (click to expand)

Cannot nix-instantiate `celf' because:
�[31;1merror:�[0m while evaluating the attribute 'buildInputs' of the derivation 'celf-2013-07-25' at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/stdenv/generic/make-derivation.nix�[0m:170:11:
while evaluating 'getOutput' at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/lib/attrsets.nix�[0m:450:23, called from undefined position:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/stdenv/generic/make-derivation.nix�[0m:108:17, called from undefined position:
callPackage_i686 not supported on system 'aarch64-linux'

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: celf

Partial log (click to expand)

[autoloading done]
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gcds7wpxqqxska1mdia9fcnbxmqxbayx-celf-2013-07-25
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gcds7wpxqqxska1mdia9fcnbxmqxbayx-celf-2013-07-25/bin
patching script interpreter paths in /nix/store/gcds7wpxqqxska1mdia9fcnbxmqxbayx-celf-2013-07-25
/nix/store/gcds7wpxqqxska1mdia9fcnbxmqxbayx-celf-2013-07-25/bin/celf: interpreter directive changed from " /bin/sh" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/gcds7wpxqqxska1mdia9fcnbxmqxbayx-celf-2013-07-25...
/nix/store/gcds7wpxqqxska1mdia9fcnbxmqxbayx-celf-2013-07-25

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: celf

Partial log (click to expand)

val it = true : bool
[autoloading]
[autoloading done]
installing
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/d8adr49xpgc6zq9r1ka9wkykr9nzsg39-celf-2013-07-25/bin
patching script interpreter paths in /nix/store/d8adr49xpgc6zq9r1ka9wkykr9nzsg39-celf-2013-07-25
/nix/store/d8adr49xpgc6zq9r1ka9wkykr9nzsg39-celf-2013-07-25/bin/celf: interpreter directive changed from " /bin/sh" to "/nix/store/i9g6883w05pyj9aa4sl8hn945qyy6j53-bash-4.4-p19/bin/sh"
/nix/store/d8adr49xpgc6zq9r1ka9wkykr9nzsg39-celf-2013-07-25

@xeji
Copy link
Contributor

xeji commented May 28, 2018

Thank you!

@xeji xeji merged commit de897ba into NixOS:master May 28, 2018
@bcdarwin bcdarwin deleted the celf branch May 28, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @xeji @GrahamcOfBorg