Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging stabilization #41138

Closed
wants to merge 540 commits into from
Closed

staging stabilization #41138

wants to merge 540 commits into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 27, 2018

Motivation for this change

https://hydra.nixos.org/eval/1459406?compare=trunk

There's a significant amount of new failures on staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
Copy link
Member

ttuegel commented May 27, 2018

A major source of failures is rustc (now needed for librsvg) which has a checkPhase failure I cannot reproduce locally.

@LnL7
Copy link
Member Author

LnL7 commented May 27, 2018

b22cc53

@LnL7 LnL7 closed this May 27, 2018
@zimbatm zimbatm deleted the staging-stabilization branch May 27, 2018 21:35
@Mic92
Copy link
Member

Mic92 commented May 27, 2018

@ttuegel do you have a link for the rust failure?

@Mic92
Copy link
Member

Mic92 commented May 27, 2018

Rustc currently fails in process::tests::test_inherit_env

Do we have non-ascii environment variables in the nix build?
rust-lang/rust#40171

@Mic92
Copy link
Member

Mic92 commented May 27, 2018

I think we can safely disable test_inherit_env as well.

@LnL7
Copy link
Member Author

LnL7 commented May 27, 2018

FYI. There's some discussion going on in #nixos-dev

@orivej orivej mentioned this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet