Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slic3r-prusa3d: 1.39.2 -> 1.40.0-beta #41151

Closed
wants to merge 1 commit into from
Closed

slic3r-prusa3d: 1.39.2 -> 1.40.0-beta #41151

wants to merge 1 commit into from

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented May 27, 2018 •
edited

Motivation for this change

We need to fix the library installation path, as PERL_VENDORLIB and
PERL_VENDORARCH are set incorrectly. This can be seen when running cmake.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

Moredread commented May 27, 2018 •
edited

As it is a alpha version we might want to wait for the stable version before merging. But I already created this PR for the PERL_VENDORLIB and PERL_VENDORARCH fix, so that it isn't lost.

BTW, the problem is already there in older versions, but this variables aren't used.

@Moredread
Copy link
Contributor Author

@tweber notifying you :) Shouldn't that happen automatically?

@xeji
Copy link
Contributor

xeji commented Jun 3, 2018

We prefer to merge stable releases, so let's wait for it (it's 1.40.0-beta now). Marking this as WIP until then.

@Moredread
slic3r-prusa3d: 1.39.2 -> 1.40.0-beta
0abf6b3 
We need to fix the library installation path, as PERL_VENDORLIB and
PERL_VENDORARCH are set incorrectly. This can be seen when running cmake.
@Moredread Moredread changed the title slic3r-prusa3d: 1.39.2 -> 1.40.0-alpha1 slic3r-prusa3d: 1.39.2 -> 1.40.0-beta Jun 4, 2018
@Moredread
Copy link
Contributor Author

Moredread commented Jun 18, 2018 •
edited

Package was updated in dcb8828 to 1.40.0

Thanks @thorstenweber83!

@Moredread Moredread closed this Jun 18, 2018
@Moredread Moredread deleted the slic3r-prusa/1.40.0-alpha0 branch June 18, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @xeji @GrahamcOfBorg