gnuradio: 3.7.11.1 -> 3.7.13.3 #41431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
requested changes
Jun 4, 2018
| # => python wrappers | ||
| # May be able to upgrade to swig3 | ||
| , python, swig2, numpy, scipy, matplotlib | ||
| # => grc - the gnu radio companion | ||
| , cheetah, pygtk | ||
| , Mako, cheetah, pygtk # Note: GR is migrating to Mako. Cheetah shoul dbe removed for GR3.8 |
| @@ -26,7 +26,13 @@ stdenv.mkDerivation rec { | |||
| grep -q "Requires:" "$pcfile" && { echo "Upstream has added 'Requires:' in $(basename "$pcfile"); update nix expression."; exit 1; } | |||
| echo "Requires: libusb-1.0" >> "$pcfile" | |||
| ''; | |||
|
|
|||
| patches = lib.optionals stdenv.isDarwin [ | |||
There was a problem hiding this comment.
Would it be possible/pertinent to open an upstream issue?
There was a problem hiding this comment.
Considering that the version didn't change, I assume the error is due to some Nix oddity. I can dig into it a bit more
lukeadams
changed the title
added 6 commits
June 26, 2018 17:04
* fixes build on Darwin. * fetch images from GH releases page (uniform versioning scheme)
* also add mako input (cheetah will be removed in GR3.8)
|
@matthewbauer It seems the changes I made to the src fetch broke the GR build. I'm also seeing the cmake/clang argument list issue again on master. I'll open a pr to fix the src but until the cmake -L explosion is fixed, I'll mark it as WIP since it won't build. Sorry about that :/ |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
nox-review completed successfully
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)