Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-dateutil 2.6.1 -> 2.7.3 #41413

Closed
wants to merge 3 commits into from
Closed

Update python-dateutil 2.6.1 -> 2.7.3 #41413

wants to merge 3 commits into from

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jun 3, 2018

Motivation for this change

Various bugfixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 3, 2018

Please rebase this PR on the staging branch since it causes >22k rebuild.

@FRidh
Copy link
Member

FRidh commented Jun 3, 2018

Bumps of this package typically cause quite some breakage, so don't merge. This needs more investigation.

@pacien pacien changed the base branch from master to staging June 3, 2018 17:57
@pacien
Copy link
Contributor Author

pacien commented Jun 3, 2018

The PR has been rebased.

Version 2.7.x (changelog) most notably drops support for Python 2.6 and 3.2, whereas versions 2.7 and 3.6 are used in NixOS. Other changes mostly consist of bug fixes, feature addition and a few deprecation. I hope this doesn't break other packages.

As a side note, updating this library would enable the resolution of some issues in other packages like this one.

@pacien
Copy link
Contributor Author

pacien commented Jun 4, 2018

Seems like this breaks a test in the vobject package: skarim/vobject#113, skarim/vobject#112

@FRidh
Copy link
Member

FRidh commented Jun 12, 2018

I've included the changes in #41894.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants