-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add NotRoadTypes (NRT) #6811
Conversation
Argument for doing 64 types initially is it saves having to add a bunch of savegame conversion code. |
Previous reviews by PeterN and TrueBrain took place in a ticket of the NRT fork (predated OpenTTD github). |
061771d
to
6595995
Compare
Rebased by Alberth using Peter's July 2018 rebase This builds and runs fine, but it's not clear yet:
With respect to 64 types (or not): this PR adds 64 types. It's the better option. Crowd-sourced opinion is that this won't have enough play-test time to make it into 1.9.0 by April 2019. It has been play-tested quite a lot already, but eh. Save it for 2.0? 🎁 |
6147526
to
77f06c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assertion failure at tile_map.h line 91 running regression tests.
77f06c4
to
5e005ae
Compare
I have rebased to master, available here https://github.com/PeterN/OpenTTD/tree/nrt-block New sprites have been split off to separate files to avoid future conflicts. I have not addressed the regression test failure. |
5e005ae
to
0d33845
Compare
The assertion failure mentioned above still happens in the regression tests. |
Yes, #7142 has only just been merged into master! |
Two issues I've noticed during gameplay testing:
|
aada649
to
6fe4eee
Compare
One-way roads have now been fixed, this was due to the 64 road types addition. The regression failure is now resolved! |
ac4f33c
to
24b6afc
Compare
ca85cd2
to
e757d2d
Compare
d978852
to
6c24853
Compare
I guess I need to come clean on this, as it seems nobody knows: this is awaiting review and approval for merging. |
If you try to "autoreplace" a ship or an aircraft, the game crashes: |
@stormcone Thanks, this has now been fixed. |
…using rail. INVALID_RAILTYPES, if it was accidentally tested, would match any railtype.
…ake sense. Road type and rail type are stored in separate locations, so this parameter does not make make sense as it is only used for rail bridges. Instead explicitly set the rail type in MakeRailBridgeRamp().
Congratulations on getting this massive update finished! 🎉 |
The number of GUI sprites has increased according to NRT (OpenTTD/OpenTTD#6811).
The number of GUI sprites has increased according to NRT (OpenTTD/OpenTTD#6811).
The 'one big diff' approach.
16 types only, PeterN has a patch for 64, but that needs finish, tested, argued about etc. Can do that later. We make progress by not waiting for perfect eh? :)
Spec: https://wiki.openttd.org/Frosch/NotRoadTypes
Want to try it out? https://www.openttd.org/downloads/openttd-pullrequests/pr6811/latest.html has precompiled binaries for you! (last updated: 24th of March 2018)